Re: Error when cloning with weird local directory

[Junio C Hamano <gitster@pobox.com>]

Junio C Hamano <gitster@pobox.com> writes:

> Torsten Bögershausen <tboegi@web.de> writes:
>
>> It looks as if
>> static char *get_repo_path(const char *repo, int *is_bundle)
>> in built/clone.c
>> checks if there is a local directory structure looking like a
>> .git directory.
>> This is wrong.
>
> It is as designed, though, to allow cloning from a local directory
> with any name.
>
>> There should be a check for the scheme first.
>
> That will be wrong.

It matters mostly when dealing with scp-like syntax, word:path.

I _think_ taking notice of "word://" (with doubled slashes) and
treating it specially will not introduce any new issue; while it is
still OK for users to have a local directory called "word:", if they
meant a subdirectory of it, they wouldn't have typed double-slashes
there.