From: Junio C Hamano <gitster@pobox.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: git@vger.kernel.org, "Jeff King" <peff@peff.net>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
"Michael Haggerty" <mhagger@alum.mit.edu>
Subject: Re: [PATCH 0/8] object_id part 2
Date: Wed, 10 Jun 2015 17:21:33 -0700 [thread overview]
Message-ID: <xmqqpp53gkmq.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20150611000251.GB786544@vauxhall.crustytoothpaste.net> (brian m. carlson's message of "Thu, 11 Jun 2015 00:02:52 +0000")
"brian m. carlson" <sandals@crustytoothpaste.net> writes:
> On Wed, Jun 10, 2015 at 11:51:14PM +0000, brian m. carlson wrote:
>> On Wed, Jun 10, 2015 at 03:50:32PM -0700, Junio C Hamano wrote:
>> > "brian m. carlson" <sandals@crustytoothpaste.net> writes:
>> > > Convert struct object to object_id
>> >
>> > It seems that the last one didn't make it...
>>
>> It appears the mail was too large for vger. Unfortunately for
>> bisectability reasons, it is necessarily large. I'll resubmit the patch
>> with less context.
>
> Unfortunately, the only patch I can generate that falls under to 100 KB
> limit is with -U0, which isn't very useful. How do you want to proceed?
> The branch is available at [0], or I can send the -U0 patch, or I can
> split it into unbisectable pieces.
>
> [0] https://github.com/bk2204/git.git object-id-part2
No approach other than just letting reviewers fetch from there and
taking a look is reasonable, I would think.
Did you create this manually, or is it a mechanical scripted rewrite
followed by manual clean-up? If the latter, it may help people by
posting the mechanical recipe _and_ a patch that shows the manual
clean-up. That is something we can reasonably review and discuss.
next prev parent reply other threads:[~2015-06-11 0:21 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-09 16:28 [PATCH 0/8] object_id part 2 brian m. carlson
2015-06-09 16:28 ` [PATCH 1/8] refs: convert some internal functions to use object_id brian m. carlson
2015-06-09 16:28 ` [PATCH 2/8] sha1_file: introduce has_object_file helper brian m. carlson
2015-06-10 9:59 ` Duy Nguyen
2015-06-10 13:55 ` brian m. carlson
2015-06-09 16:28 ` [PATCH 3/8] Convert struct ref to use object_id brian m. carlson
2015-06-11 15:41 ` Michael Haggerty
2015-06-09 16:28 ` [PATCH 4/8] Add a utility function to make parsing hex values easier brian m. carlson
2015-06-11 16:09 ` Michael Haggerty
2015-06-09 16:28 ` [PATCH 5/8] add_sought_entry_mem: convert to struct object_id brian m. carlson
2015-06-09 16:28 ` [PATCH 6/8] parse_fetch: convert to use " brian m. carlson
2015-06-09 16:28 ` [PATCH 7/8] ref_newer: " brian m. carlson
2015-06-10 22:50 ` [PATCH 0/8] object_id part 2 Junio C Hamano
2015-06-10 23:51 ` brian m. carlson
2015-06-11 0:02 ` brian m. carlson
2015-06-11 0:21 ` Junio C Hamano [this message]
2015-06-11 3:31 ` brian m. carlson
2015-06-11 20:00 ` Junio C Hamano
2015-06-12 20:30 ` brian m. carlson
2015-06-12 22:14 ` Junio C Hamano
2015-06-12 22:27 ` brian m. carlson
2015-06-13 8:45 ` Michael Haggerty
2015-06-13 15:28 ` brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpp53gkmq.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=mhagger@alum.mit.edu \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.