From: Junio C Hamano <gitster@pobox.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Patryk Obara <patryk.obara@gmail.com>, Git List <git@vger.kernel.org>
Subject: Re: [PATCH 2/2] commit: fix ending newline for template files
Date: Thu, 28 May 2015 11:22:15 -0700 [thread overview]
Message-ID: <xmqqpp5kh8a0.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CAPig+cTt5sQ=49qS2+8ZOtiX61kHjAisAvpP7K3XPhtNtCatOg@mail.gmail.com> (Eric Sunshine's message of "Thu, 28 May 2015 10:29:18 -0400")
Eric Sunshine <sunshine@sunshineco.com> writes:
> Moreover, it lacks justification and explanation of why you consider
> the cleanup unnecessary. History [1] indicates that its application to
> -F but not -t was intentional.
>
> [1]: bc92377 (commit: fix ending newline for template files, 2015-05-26)
Sorry, but the date of that commit seems to be too new to be
considered "history"; I do not seem to have it, either.
But I agree with you that I too failed to see why this change is
necessary or desirable in the explanation in the proposed log
message.
next prev parent reply other threads:[~2015-05-28 18:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-26 6:15 [PATCH 0/2] commit -t appends newline after template file Patryk Obara
2015-05-26 6:15 ` [PATCH 1/2] t750*: make tests for commit messages more pedantic Patryk Obara
2015-05-28 13:34 ` Eric Sunshine
2015-05-28 18:55 ` Junio C Hamano
2015-05-26 6:15 ` [PATCH 2/2] commit: fix ending newline for template files Patryk Obara
2015-05-28 14:29 ` Eric Sunshine
2015-05-28 18:22 ` Junio C Hamano [this message]
2015-05-28 18:35 ` Eric Sunshine
2015-05-29 20:17 ` Junio C Hamano
2015-05-29 22:25 ` Eric Sunshine
2015-05-30 11:29 ` Patryk Obara
2015-05-31 2:21 ` Eric Sunshine
2015-05-30 16:59 ` Junio C Hamano
2015-05-28 10:06 ` [PATCH 0/2] commit -t appends newline after template file Patryk Obara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpp5kh8a0.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=patryk.obara@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.