All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "Kyle J. McKay" <mackyle@gmail.com>,
	Jonathon Mah <me@jonathonmah.com>,
	Git mailing list <git@vger.kernel.org>
Subject: Re: [PATCH] sha1_file.c: make sure open_sha1_file does not open a directory
Date: Mon, 09 Feb 2015 10:48:40 -0800	[thread overview]
Message-ID: <xmqqpp9ic453.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20150209005444.GA16827@peff.net> (Jeff King's message of "Sun, 8 Feb 2015 19:54:44 -0500")

Jeff King <peff@peff.net> writes:

> However, the first thing for_each_loose_file_in_objdir is going to do is
> stick the path into a strbuf. So perhaps the most sensible thing is to
> just teach it to take a strbuf from the caller. I'll work up a patch.
>
> It looks like a1b47246 isn't even in "next" yet, so I'll build it
> directly on what is already in master, dropping Jonathan's patch.

Thanks; looks very sensible.

      parent reply	other threads:[~2015-02-09 18:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-08 23:05 [PATCH] sha1_file.c: make sure open_sha1_file does not open a directory Kyle J. McKay
2015-02-09  0:54 ` Jeff King
2015-02-09  1:12   ` Jeff King
2015-02-09  1:13     ` [PATCH 1/2] for_each_loose_file_in_objdir: take an optional strbuf path Jeff King
2015-02-09  1:15     ` [PATCH 2/2] sha1_file: fix iterating loose alternate objects Jeff King
2015-02-09  9:44       ` Kyle J. McKay
2015-02-09 18:48   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqpp9ic453.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=mackyle@gmail.com \
    --cc=me@jonathonmah.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.