From: Junio C Hamano <gitster@pobox.com>
To: Alexander Kuleshov <kuleshovmail@gmail.com>
Cc: "git\@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH] format-patch: print format-patch usage if there are no arguments
Date: Tue, 13 Jan 2015 11:17:51 -0800 [thread overview]
Message-ID: <xmqqppaicwww.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CANCZXo7UtCXF_bJe9exT1pUwwsgUuYs5mvHHGtDORoJew_UXnQ@mail.gmail.com> (Alexander Kuleshov's message of "Wed, 14 Jan 2015 00:52:27 +0600")
Alexander Kuleshov <kuleshovmail@gmail.com> writes:
> 2015-01-14 0:43 GMT+06:00 Junio C Hamano <gitster@pobox.com>:
>> Why?
>
> As some commands does it when they are executed without arguments,
> like git config, git blame and etc...
For format-patch, I think the current behaviour is more of the lack
of implementation of the obvious default. "git blame" does not have
any obvious default (would there be a single file you would want to
dig the history when the user does not tell you which one? No), so
it proabaly is the right thing to do to error out.
But I would not surprised if those who build on top of others' work
to wish that "git format-patch" that was invoked without argument on
a branch created by "git checkout -t -b" to default to format commits
since the branch forked from @{upstream}, for example.
next prev parent reply other threads:[~2015-01-13 19:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-13 17:54 [PATCH] format-patch: print format-patch usage if there are no arguments Alexander Kuleshov
2015-01-13 18:43 ` Junio C Hamano
2015-01-13 18:52 ` Alexander Kuleshov
2015-01-13 19:17 ` Junio C Hamano [this message]
2015-01-13 20:00 ` Stefan Beller
2015-01-13 22:28 ` Junio C Hamano
2015-01-13 22:45 ` Jeff King
2015-01-13 22:48 ` Stefan Beller
2015-01-14 1:28 ` my hacky mutt-specific format-patch workflow Jeff King
2015-01-13 23:41 ` [PATCH] format-patch: print format-patch usage if there are no arguments Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqppaicwww.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=kuleshovmail@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.