From: Junio C Hamano <gitster@pobox.com>
To: Mark Levedahl <mlevedahl@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] remote.c - Make remote definition require a url
Date: Mon, 13 Oct 2014 10:19:24 -0700 [thread overview]
Message-ID: <xmqqppdv51lv.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1413040849-20056-1-git-send-email-mlevedahl@gmail.com> (Mark Levedahl's message of "Sat, 11 Oct 2014 11:20:49 -0400")
Mark Levedahl <mlevedahl@gmail.com> writes:
> Some options may be configured globally for a remote (e.g, tagopt).
Or some remotes may have only pushurl and not url. "git remote"
output for me has a few such remotes but wouldn't this patch break
it?
If a caller that walks the list of remotes misbehaves only because
it assumes that r->url always is always valid, isn't that assumption
what needs to be fixed? for_each_remote() should be kept as a way
to enumerate all the [remote "foo"], I would think.
next prev parent reply other threads:[~2014-10-13 17:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-11 15:20 [PATCH] remote.c - Make remote definition require a url Mark Levedahl
2014-10-13 17:19 ` Junio C Hamano [this message]
2014-10-14 1:05 ` Mark Levedahl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqppdv51lv.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=mlevedahl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.