From mboxrd@z Thu Jan 1 00:00:00 1970 From: Junio C Hamano Subject: Re: [PATCH v1 1/3] dir.c: coding style fix Date: Tue, 15 Jul 2014 12:10:14 -0700 Message-ID: References: <53C3A71F.1020101@gmail.com> <53C579B4.2050506@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Git List , Duy Nguyen To: Karsten Blees X-From: git-owner@vger.kernel.org Tue Jul 15 21:10:28 2014 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1X787P-0002Cw-8w for gcvg-git-2@plane.gmane.org; Tue, 15 Jul 2014 21:10:27 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932885AbaGOTKY convert rfc822-to-quoted-printable (ORCPT ); Tue, 15 Jul 2014 15:10:24 -0400 Received: from smtp.pobox.com ([208.72.237.35]:50221 "EHLO smtp.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932760AbaGOTKW convert rfc822-to-8bit (ORCPT ); Tue, 15 Jul 2014 15:10:22 -0400 Received: from smtp.pobox.com (unknown [127.0.0.1]) by pb-smtp0.pobox.com (Postfix) with ESMTP id 6442529C58; Tue, 15 Jul 2014 15:10:04 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=yjWdQbRPz2io QcLvLlblEitqTXk=; b=TWE5/wdYVSfo7SUdMZl+tsKyGNb4v8ZmcOViggP2NxA4 tACRCYkYF2mKOlFSgHM1izGs0moHvCk3CRKIEXjMfzUSBPLwJKInz04Cbw0wOetW 7l1h7BR7DWRMzzBGyiCyeZGXf58VhNQ4yokxbx2bBEzWBov6h5RG1OhWhHvYCq0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; q=dns; s=sasl; b=IihNPP zdIMwuQ7fOjgr4Tuv83N0K2oFAESvBMhJfN4qqGbRyFVb1TSbaucGtdaDqCTQfbH pdnAEcKxA10NyEExBxMyH0EhNpipgh3mVuvCTBe2xKQ4baAM1QB1Mjrg70M3n5Ep ODwgudpkcu5Pt5BIw+FwNaXcYm09zhFAehNSU= Received: from pb-smtp0.int.icgroup.com (unknown [127.0.0.1]) by pb-smtp0.pobox.com (Postfix) with ESMTP id 2A17629C57; Tue, 15 Jul 2014 15:10:04 -0400 (EDT) Received: from pobox.com (unknown [72.14.226.9]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by pb-smtp0.pobox.com (Postfix) with ESMTPSA id 41C3029C4C; Tue, 15 Jul 2014 15:09:58 -0400 (EDT) In-Reply-To: <53C579B4.2050506@gmail.com> (Karsten Blees's message of "Tue, 15 Jul 2014 20:57:56 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) X-Pobox-Relay-ID: 9CF2AD5A-0C53-11E4-A5A2-9903E9FBB39C-77302942!pb-smtp0.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Karsten Blees writes: > Am 15.07.2014 00:30, schrieb Junio C Hamano: >> Karsten Blees writes: >>=20 >>> From: =3D?UTF-8?q?Nguy=3DE1=3DBB=3D85n=3D20Th=3DC3=3DA1i=3D20Ng=3DE= 1=3DBB=3D8Dc=3D20Duy?=3D >>> >>> >>> Signed-off-by: Nguy=E1=BB=85n Th=C3=A1i Ng=E1=BB=8Dc Duy >>> Signed-off-by: Karsten Blees >>> --- >>=20 >> Thanks for forwarding. I'll fix-up the Yikes (see how these two >> lines show the same name in a very different way), but how did you >> produce the above? Is there some fix we need in the toolchain that >> produces patch e-mails? >>=20 > > Hmmm...I simply thought that this is how its supposed to work. Mail > headers can only contain US-ASCII, so the RFC 2047 Q-encoded-word > generated by git-format-patch looked good to me. But that quoted one is *NOT* a mail header. It is the first line of the payload of your message, and should be in plain text just like the remainder, e.g. S-o-b line that has the same name. > Perhaps it should be clarified that git-format-patch output is not > suitable for pasting into mail clients? Or it should print headers > in plain text and let git-send-email handle the conversions? If the former is missing, then we should definitely add it to the documentation. We often see new people pasting the "From " line meant for /etc/magic and unwanted {From,Subject,Date}: in the body. We may also want to add an option to tell it to produce an output that is suitable for pasting into mail clients. Hint, hint...