From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/2] inline constant return from error() function
Date: Sun, 11 May 2014 10:22:03 -0700 [thread overview]
Message-ID: <xmqqppjkut6s.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20140507030254.GC20726@sigill.intra.peff.net> (Jeff King's message of "Tue, 6 May 2014 23:02:54 -0400")
Jeff King <peff@peff.net> writes:
> On Tue, May 06, 2014 at 03:29:37PM -0700, Junio C Hamano wrote:
>
>> That's kind of W*A*T magic, and I generally try to avoid magic, as
>> long as it solves your "can we make both -O2 with new compilers and
>> -O3 happy?" I wouldn't complain ;-)
>
> I agree it's rather magical, but I think it's something we can count on.
Certainly. Sorry that I missed "but" before "as long as", which made
me sound as if I were unhappy. At least, I didn't call it an ugly
"hack" ;-)
The alternative you mentioned up-thread "... to write out "return
error(...)" as "error(...); return -1". In some ways that is more
readable, though it is more verbose..." has one more downside you
did not mention, and the approach to encapsulate it inside error()
will not have it: new call-sites to error() do not have to worry
about the issue with this approach.
Until it breaks, that is. But that goes without saying with the
"it's something we can count on" pre-condition in place ;-).
next prev parent reply other threads:[~2014-05-11 17:24 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-04 6:12 [PATCH 0/3] Fix a ton of compiler warnings Felipe Contreras
2014-05-04 6:12 ` [PATCH 1/3] Revert "make error()'s constant return value more visible" Felipe Contreras
2014-05-05 5:49 ` Jeff King
2014-05-05 5:45 ` Felipe Contreras
2014-05-05 6:02 ` Jeff King
2014-05-05 6:14 ` Felipe Contreras
2014-05-05 6:29 ` Jeff King
2014-05-05 7:30 ` Felipe Contreras
2014-05-05 21:29 ` Jeff King
2014-05-06 15:14 ` [PATCH 1/2] inline constant return from error() function Jeff King
2014-05-06 22:29 ` Junio C Hamano
2014-05-07 3:02 ` Jeff King
2014-05-11 17:22 ` Junio C Hamano [this message]
2014-05-12 18:13 ` Jeff King
2014-05-11 7:13 ` Felipe Contreras
2014-05-12 18:44 ` Jonathan Nieder
2014-05-12 18:56 ` Jeff King
2014-05-06 15:17 ` [PATCH 2/2] let clang use the constant-return error() macro Jeff King
2014-05-04 6:12 ` [PATCH 2/3] Revert "silence some -Wuninitialized false positives" Felipe Contreras
2014-05-04 6:12 ` [PATCH 3/3] Silence a bunch of format-zero-length warnings Felipe Contreras
2014-05-04 19:01 ` brian m. carlson
2014-05-04 20:13 ` Felipe Contreras
2014-05-05 5:21 ` Jeff King
2014-05-07 18:19 ` Junio C Hamano
2014-05-07 20:05 ` Heiko Voigt
2014-05-07 20:31 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqppjkut6s.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.