From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Lianheng Tong <lianheng.tong@kcl.ac.uk>,
git@vger.kernel.org, Jens Lehmann <Jens.Lehmann@web.de>,
Heiko Voigt <hvoigt@hvoigt.net>
Subject: Re: Submodule relative URL problems
Date: Mon, 13 Jan 2014 12:44:07 -0800 [thread overview]
Message-ID: <xmqqppnv6294.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20140113195518.GB18964@google.com> (Jonathan Nieder's message of "Mon, 13 Jan 2014 11:55:18 -0800")
Jonathan Nieder <jrnieder@gmail.com> writes:
> * More typical usage is to clone from a bare repository (A.git), which
> wouldn't have this problem. But I think your case is worth
> supporting, too.
I think the relative URL among nested submodules was specifically
designed for hosting environments that have forest of bare
repositories to serve as publishing or meeting points. I personally
do not know where that "worth supporting" comes from, but if the
change can be done without confusing the codepaths involved, I
wouldn't object too much ;-)
> * Perhaps as a special case when the superproject is foo/.git, git
> should treat relative submodule paths as relative to foo/ instead
> of relative to foo/.git/. I think that would take care of your
> case without breaking existing normal practices, though after the
> patch is made it still wouldn't take care of people using old
> versions of git without that patch. What do you think?
If we were to start adding special cases, it may also be sensible to
clean up the more normal case of using subdirectories of bare
repositories to represent nestedness (i.e. you can have a submodule
"logs.git", but not "logs"). We could reuse the $GIT_DIR/modules/$sm_name
convention somehow perhaps?
Any change to implement the special case you suggest likely has to
touch the same place as such a change does, as both require some
reorganization of the code that traverses the pathnames to find
related repositories.
prev parent reply other threads:[~2014-01-13 20:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <DC691CA7-BE36-4FE7-895A-FE8E1FD0C080@kcl.ac.uk>
2014-01-13 14:02 ` Submodule relative URL problems Lianheng Tong
2014-01-13 19:55 ` Jonathan Nieder
2014-01-13 20:31 ` Heiko Voigt
2014-01-13 20:44 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqppnv6294.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=Jens.Lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=hvoigt@hvoigt.net \
--cc=jrnieder@gmail.com \
--cc=lianheng.tong@kcl.ac.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.