All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Michael Montalbo <mmontalbo@gmail.com>
Cc: code@khaugsbakk.name,  git@vger.kernel.org
Subject: Re: [PATCH v3] SubmittingPatches: address design critiques
Date: Sat, 20 Jun 2026 07:09:17 -0700	[thread overview]
Message-ID: <xmqqqzm1gv76.fsf@gitster.g> (raw)
In-Reply-To: <CAC2Qwm+WcGkd9pAV5=JL1hfCDRisGQRFmdfOsMTrMWyx7aa65A@mail.gmail.com> (Michael Montalbo's message of "Fri, 19 Jun 2026 15:40:51 -0700")

Michael Montalbo <mmontalbo@gmail.com> writes:

> Slight reflow suggestions:
>
>   Defend your design decisions on the list first; work with reviewers and
>   other members to improve the design before revising the implementation.
>   This will avoid wasting effort on an implementation before its design is
>   solid.

Yeah, making the last part a separate sentence does make it much
easier to follow.  Will use.

Thanks.

  reply	other threads:[~2026-06-20 14:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-19 22:40 [PATCH v3] SubmittingPatches: address design critiques Michael Montalbo
2026-06-20 14:09 ` Junio C Hamano [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-06-17 16:06 [PATCH] " Junio C Hamano
2026-06-18  8:50 ` [PATCH v2] " Junio C Hamano
2026-06-19 16:17   ` [PATCH v3] " Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqqzm1gv76.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=code@khaugsbakk.name \
    --cc=git@vger.kernel.org \
    --cc=mmontalbo@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.