From: Junio C Hamano <gitster@pobox.com>
To: "D. Ben Knoble" <ben.knoble@gmail.com>
Cc: Phillip Wood <phillip.wood123@gmail.com>,
Javier Bassi <javierbassi@gmail.com>,
git@vger.kernel.org,
Abraham Samuel Adekunle <abrahamadekunle50@gmail.com>,
Rene Scharfe <l.s.r@web.de>, Elijah Newren <newren@gmail.com>,
Ruben Justo <rjusto@gmail.com>, Patrick Steinhardt <ps@pks.im>
Subject: Re: [PATCH] add -p: introduce 'w' command to view hunk with --word-diff
Date: Mon, 11 May 2026 09:16:23 +0900 [thread overview]
Message-ID: <xmqqqznix0ko.fsf@gitster.g> (raw)
In-Reply-To: <CALnO6CCsOMyLxAhGW10L4duaahUORwedfmtdpY3zDGpQcZoP2Q@mail.gmail.com> (D. Ben Knoble's message of "Thu, 7 May 2026 10:39:03 -0400")
"D. Ben Knoble" <ben.knoble@gmail.com> writes:
> I concur, though I wonder what other diff options would be useful. I
> can imagine a world where "add --patch" allows to reshow the patch
> with any set of custom options. Spitballing…
>
> :show <opts>
>
> …could work, since we have room to allow long-form commands still.
> This could be extended to arbitrary git-* commands, and ":!cmd" could
> be used for shelling out.
> (Can you tell I use Vim?)
>
> Anyway, what I like about this is we don't have to worry about running
> out of (or thinking up new mnemonics for) single letters for different
> combinations of diff options, so it's a bit more extensible.
If you mean "don't waste a new letter, like 'w', every time you come
up with a use case to show the patch hunk differently", I had the
same reaction to suggest reusing 'p' but allow options after it,
just like the output from "git diff" can be modified by giving it an
option "--word-diff". But how would it work for single-key folks (I
am not one of them so I have less sympathy than I should in this
case, but still...).
next prev parent reply other threads:[~2026-05-11 0:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-06 23:54 [PATCH] add -p: introduce 'w' command to view hunk with --word-diff Javier Bassi
2026-05-07 7:55 ` Pablo
2026-05-07 13:24 ` Phillip Wood
2026-05-07 14:53 ` Pablo
2026-05-07 13:24 ` Phillip Wood
2026-05-07 14:39 ` D. Ben Knoble
2026-05-11 0:16 ` Junio C Hamano [this message]
2026-05-11 19:16 ` D. Ben Knoble
2026-05-12 0:04 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqqznix0ko.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=abrahamadekunle50@gmail.com \
--cc=ben.knoble@gmail.com \
--cc=git@vger.kernel.org \
--cc=javierbassi@gmail.com \
--cc=l.s.r@web.de \
--cc=newren@gmail.com \
--cc=phillip.wood123@gmail.com \
--cc=ps@pks.im \
--cc=rjusto@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.