From: Junio C Hamano <gitster@pobox.com>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: Patrick Steinhardt <ps@pks.im>, GIT Mailing-list <git@vger.kernel.org>
Subject: Re: Subject: [PATCH] object-file: fix sparse 'plain integer as NULL pointer' error
Date: Thu, 19 Mar 2026 18:35:11 -0700 [thread overview]
Message-ID: <xmqqqzpfgu5s.fsf@gitster.g> (raw)
In-Reply-To: <97c623fe-4e03-4fbe-a6af-9c01c101bae4@ramsayjones.plus.com> (Ramsay Jones's message of "Thu, 19 Mar 2026 22:49:06 +0000")
Ramsay Jones <ramsay@ramsayjones.plus.com> writes:
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>
> Hi Patrick,
>
> When you next re-roll your 'ps/object-counting' branch, could you please squash this
> into the patch equivalent to the commit 2b24db1110 ("object-file: generalize counting
> objects",2026-03-12) in tonight's 'seen' branch.
The topic being in 'next' since March 17th, that is a bit awkward to
arrange. I can queue the fix on top instead.
>
> Thanks,
>
> ATB,
> Ramsay Jones
>
>
> object-file.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/object-file.c b/object-file.c
> index 35be7e58cb..3708b8f18d 100644
> --- a/object-file.c
> +++ b/object-file.c
> @@ -1941,7 +1941,7 @@ int odb_source_loose_count_objects(struct odb_source *source,
> } else {
> *out = 0;
> ret = odb_source_loose_for_each_object(source, NULL, count_loose_object,
> - out, 0);
> + out, NULL);
> }
>
> out:
next prev parent reply other threads:[~2026-03-20 1:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-19 22:49 Subject: [PATCH] object-file: fix sparse 'plain integer as NULL pointer' error Ramsay Jones
2026-03-20 1:35 ` Junio C Hamano [this message]
2026-03-20 2:04 ` Ramsay Jones
2026-03-20 3:44 ` Ramsay Jones
2026-03-20 6:14 ` Patrick Steinhardt
2026-03-20 6:05 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqqzpfgu5s.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.