From: Junio C Hamano <gitster@pobox.com>
To: Derrick Stolee <stolee@gmail.com>
Cc: Amisha Chhajed <amishhhaaaa@gmail.com>,
git@vger.kernel.org, Elijah Newren <newren@gmail.com>,
Jeff King <peff@peff.net>
Subject: Re: [PATCH v7] sparse-checkout: optimize string_list construction and add tests to verify deduplication.
Date: Wed, 21 Jan 2026 08:51:51 -0800 [thread overview]
Message-ID: <xmqqqzrivrh4.fsf@gitster.g> (raw)
In-Reply-To: <615b31c3-a47a-43bc-8dcf-7943ead101a7@gmail.com> (Derrick Stolee's message of "Wed, 21 Jan 2026 11:28:06 -0500")
Derrick Stolee <stolee@gmail.com> writes:
> On 1/21/2026 8:00 AM, Amisha Chhajed wrote:
>> Improve O(n^2) complexity to O(n log n) while building a sorted
>> 'string_list' by constructing it unsorted then sorting it
>> followed by removing duplicates.
>
> Thanks for iterating on this. I think v7 is good to go.
>
> Thanks,
> -Stolee
Thanks, both.
prev parent reply other threads:[~2026-01-21 16:51 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-14 19:28 [PATCH] sparse-checkout: optimize string_list construction amisha
2026-01-14 21:35 ` Jeff King
2026-01-18 2:39 ` Derrick Stolee
2026-01-15 12:56 ` [PATCH v2] " amisha
2026-01-15 13:09 ` [PATCH v3] " amisha
2026-01-15 13:15 ` Amisha Chhajed
2026-01-15 20:09 ` Jeff King
2026-01-16 17:03 ` Amisha Chhajed
2026-01-15 22:26 ` René Scharfe
2026-01-16 8:30 ` Amisha Chhajed
2026-01-16 17:17 ` Junio C Hamano
2026-01-18 2:46 ` Derrick Stolee
2026-01-18 13:09 ` Amisha Chhajed
2026-01-15 13:55 ` Junio C Hamano
2026-01-16 16:50 ` [PATCH] " amisha
2026-01-16 19:11 ` Junio C Hamano
2026-01-18 13:07 ` Amisha Chhajed
2026-01-19 5:32 ` Jeff King
2026-01-19 19:06 ` Junio C Hamano
2026-01-19 12:33 ` [PATCH v5 1/2] " amisha
2026-01-19 17:04 ` Derrick Stolee
2026-01-19 18:33 ` Pushkar Singh
2026-01-20 15:47 ` Amisha Chhajed
2026-01-20 15:38 ` [PATCH v6] sparse-checkout: optimize string_list construction and add tests to verify deduplication amisha
2026-01-20 20:37 ` Derrick Stolee
2026-01-21 13:00 ` [PATCH v7] " Amisha Chhajed
2026-01-21 16:28 ` Derrick Stolee
2026-01-21 16:51 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqqzrivrh4.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=amishhhaaaa@gmail.com \
--cc=git@vger.kernel.org \
--cc=newren@gmail.com \
--cc=peff@peff.net \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.