From: Junio C Hamano <gitster@pobox.com>
To: "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH] ci(dockerized): do show the result of failing tests again
Date: Sat, 22 Nov 2025 18:41:06 -0800 [thread overview]
Message-ID: <xmqqqztp1nel.fsf@gitster.g> (raw)
In-Reply-To: <xmqqpl9gike6.fsf@gitster.g> (Junio C. Hamano's message of "Mon, 17 Nov 2025 10:28:17 -0800")
Junio C Hamano <gitster@pobox.com> writes:
>> The solution is simple: make the file world-writable.
>
> I expected to see a+w not o+w from this statement; as long as it
> works I have no strong objections, but if I saw o+w without the
> above explanation I would probably have wondered who are in the
> group that we do not want this file touched by.
> ...
>> - run: useradd builder --create-home
>> - run: chown -R builder .
>> - - run: sudo --preserve-env --set-home --user=builder ci/run-build-and-tests.sh
>> + - run: chmod o+w $GITHUB_ENV && sudo --preserve-env --set-home --user=builder ci/run-build-and-tests.sh
>> - name: print test failures
Unless I hear that "user X belongs to the same group as our user
that runs 'chmod' on $GITHUB_ENV, and we do not want that user to be
writing into the file", I'll amend the patch text to match the
"solution" described in the proposed log message to "chmod a+w",
before we mark the topic for 'next'.
Thanks.
next prev parent reply other threads:[~2025-11-23 2:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-17 17:04 [PATCH] ci(dockerized): do show the result of failing tests again Johannes Schindelin via GitGitGadget
2025-11-17 18:28 ` Junio C Hamano
2025-11-23 2:41 ` Junio C Hamano [this message]
2025-11-18 9:36 ` Jeff King
2025-11-25 6:15 ` Elijah Newren
2025-11-25 14:32 ` Junio C Hamano
2025-11-25 17:40 ` Johannes Schindelin
2025-11-25 19:27 ` Junio C Hamano
2025-11-29 18:31 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqqztp1nel.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=johannes.schindelin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.