All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Collin Funk <collin.funk1@gmail.com>
Cc: Brad Smith <brad@comstyle.com>,  git@vger.kernel.org
Subject: Re: [PATCH] builtin/gc: correct physical memory detection for OpenBSD / NetBSD
Date: Sun, 01 Jun 2025 19:00:17 -0700	[thread overview]
Message-ID: <xmqqr002vr66.fsf@gitster.g> (raw)
In-Reply-To: <87h60z6i5o.fsf@gmail.com> (Collin Funk's message of "Sun, 01 Jun 2025 18:34:11 -0700")

Collin Funk <collin.funk1@gmail.com> writes:

> Hi Brad,
>
> You wrote:
>
>> OpenBSD / NetBSD use HW_PHYSMEM64 to detect the amount of physical
>> memory in a system. HW_PHYSMEM will not provide the correct amount
>> on a system with >=4GB of memory.
>>
>> Signed-off-by: Brad Smith <brad@comstyle.com>
>> ---
>> builtin/gc.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> I confirm this patch is correct.
>
> Reviewed-by: Collin Funk <collin.funk1@gmail.com>

Thanks (also thanks for the online_cpus() one).

  reply	other threads:[~2025-06-02  2:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-02  1:34 [PATCH] builtin/gc: correct physical memory detection for OpenBSD / NetBSD Collin Funk
2025-06-02  2:00 ` Junio C Hamano [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-06-01  8:24 Brad Smith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqr002vr66.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=brad@comstyle.com \
    --cc=collin.funk1@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.