From: Junio C Hamano <gitster@pobox.com>
To: "D. Ben Knoble" <ben.knoble@gmail.com>
Cc: Adam Murray via GitGitGadget <gitgitgadget@gmail.com>,
Adam Murray <ad@canva.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
git@vger.kernel.org
Subject: Re: [PATCH v2] trace2: prevent segfault on config collection where no value specified
Date: Thu, 23 Jan 2025 10:02:45 -0800 [thread overview]
Message-ID: <xmqqr04ts916.fsf@gitster.g> (raw)
In-Reply-To: <CALnO6CDH1aQrq0tcvr4rEGukksYv5bJ9W4icqBUC2Z3AyixRUw@mail.gmail.com> (D. Ben Knoble's message of "Thu, 23 Jan 2025 12:01:40 -0500")
"D. Ben Knoble" <ben.knoble@gmail.com> writes:
> I was curious what changed, so I found 792a3850fa (trace2: prevent
> segfault on config collection with valueless true, 2025-01-10) and I
> noticed this:
>
> - redacted = redact_arg(value);
> + redacted = value ? redact_arg(value): NULL;
Oh, I do not think I tweaked any of the code, other than fixing the
new test that was not properly formatted. Mostly I touched up the
log message.
Will touch it up. Thanks for a careful reading.
next prev parent reply other threads:[~2025-01-23 18:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-07 0:04 [PATCH] trace2: prevent segfault on config collection where no value specified Adam Murray via GitGitGadget
2024-11-07 2:01 ` Jeff King
2024-11-07 3:02 ` Junio C Hamano
2025-01-10 7:28 ` [PATCH v2] " Adam Murray via GitGitGadget
2025-01-10 17:10 ` Junio C Hamano
2025-01-22 10:11 ` Johannes Schindelin
2025-01-22 18:12 ` Junio C Hamano
2025-01-22 18:18 ` Junio C Hamano
2025-01-23 17:01 ` D. Ben Knoble
2025-01-23 18:02 ` Junio C Hamano [this message]
2025-01-23 21:15 ` D. Ben Knoble
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr04ts916.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=ad@canva.com \
--cc=ben.knoble@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.