All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org,  Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH 1/5] t7300: work around platform-specific behaviour with long paths on MinGW
Date: Wed, 09 Oct 2024 11:31:25 -0700	[thread overview]
Message-ID: <xmqqr08pruv6.fsf@gitster.g> (raw)
In-Reply-To: <bdaf16a06168b7320e8dd1115258f00745a104c7.1728480039.git.ps@pks.im> (Patrick Steinhardt's message of "Wed, 9 Oct 2024 15:25:18 +0200")

Patrick Steinhardt <ps@pks.im> writes:

> diff --git a/t/t7300-clean.sh b/t/t7300-clean.sh
> index 0aae0dee67..12ab25296b 100755
> --- a/t/t7300-clean.sh
> +++ b/t/t7300-clean.sh
> @@ -747,7 +747,7 @@ test_expect_success MINGW 'handle clean & core.longpaths = false nicely' '
>  	test_must_fail git clean -xdf 2>.git/err &&
>  	# grepping for a strerror string is unportable but it is OK here with
>  	# MINGW prereq

I find it amusing that this talks about limiting the test to MINGW
yet we need to accept two variants ;-)

> -	test_grep "too long" .git/err
> +	test_grep -e "too long" -e "No such file or directory" .git/err
>  '

The solution looks obviously good enough.

Thanks.

  reply	other threads:[~2024-10-09 18:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-09 13:25 [PATCH 0/5] Wire up Windows-based jobs in GitLab CI Patrick Steinhardt
2024-10-09 13:25 ` [PATCH 1/5] t7300: work around platform-specific behaviour with long paths on MinGW Patrick Steinhardt
2024-10-09 18:31   ` Junio C Hamano [this message]
2024-10-10  5:56     ` Patrick Steinhardt
2024-10-09 13:25 ` [PATCH 2/5] ci: create script to set up Git for Windows SDK Patrick Steinhardt
2024-10-09 13:25 ` [PATCH 3/5] ci: handle Windows-based CI jobs in GitLab CI Patrick Steinhardt
2024-10-09 13:25 ` [PATCH 4/5] gitlab-ci: introduce stages and dependencies Patrick Steinhardt
2024-10-09 13:25 ` [PATCH 5/5] gitlab-ci: exercise Git on Windows Patrick Steinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqr08pruv6.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=johannes.schindelin@gmx.de \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.