All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: "Jean-Noël Avila" <jn.avila@free.fr>,
	"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
	"Jean-Noël Avila via GitGitGadget" <gitgitgadget@gmail.com>,
	git@vger.kernel.org
Subject: Re: [PATCH] doc: git-clone fix discrepancy between asciidoc and asciidoctor
Date: Tue, 23 Jul 2024 11:04:00 -0700	[thread overview]
Message-ID: <xmqqr0bk0yun.fsf@gitster.g> (raw)
In-Reply-To: <CAPig+cQK17Xt6p7PSO4Mn1CLx_ayceQdj8ZY1zBVG6-c33OvsQ@mail.gmail.com> (Eric Sunshine's message of "Tue, 23 Jul 2024 13:47:47 -0400")

Eric Sunshine <sunshine@sunshineco.com> writes:

> On Tue, Jul 23, 2024 at 1:44 PM Junio C Hamano <gitster@pobox.com> wrote:
>> Subject: [PATCH] Doc: fix Asciidoctor css workaround
>>
>> The previous step introduced docinfo.html to be used to tweak the
>> CSS used by the asciidoctor, that by default renders <code> inside
>> <pre> as a block element, breaking the SYNOPSIS section of a few
>> pages that adopted a new convention we use since Git 2.45.
>>
>> But in this project, HTML files are all generated.  We do not force
>> any human to write HTML by hand, which is an unusual and cruel
>> punishment.  "*.html" is in the .gitignore file, and "make clean"
>> removes them.  Having a tracked .html file makes "make clean" make
>> the tree dirty by removing the tracked docinfo.html file.
>>
>> Let's do an obvious, minimum and stupid workaround to generate that
>> file at runtime instead.  The mark-up is being rethought in a major
>> way for the next development cycle, so what the CSS workaround we
>
> Perhaps? s/what/that/

Thanks, I ended up doing "so what" -> "and".

>> added in the previous step may have to adjusted, possibly in a large
>> way, anyway.
>>
>> Signed-off-by: Junio C Hamano <gitster@pobox.com>

      reply	other threads:[~2024-07-23 18:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-20 17:34 [PATCH] doc: git-clone fix discrepancy between asciidoc and asciidoctor Jean-Noël Avila via GitGitGadget
2024-07-20 23:16 ` Junio C Hamano
2024-07-20 23:23   ` Junio C Hamano
2024-07-21 13:08   ` Jean-Noël AVILA
2024-07-22 16:39     ` Junio C Hamano
2024-07-23 11:06       ` Jean-Noël Avila
2024-07-23 15:52         ` Junio C Hamano
2024-07-23 17:44           ` Junio C Hamano
2024-07-23 17:47             ` Eric Sunshine
2024-07-23 18:04               ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqr0bk0yun.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=jn.avila@free.fr \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.