All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "Eric Sunshine" <ericsunshine@charter.net>,
	git@vger.kernel.org, "René Scharfe" <l.s.r@web.de>,
	"Eric Sunshine" <sunshine@sunshineco.com>
Subject: Re: [PATCH] chainlint.pl: recognize test bodies defined via heredoc
Date: Sat, 06 Jul 2024 15:15:32 -0700	[thread overview]
Message-ID: <xmqqr0c6makb.fsf@gitster.g> (raw)
In-Reply-To: <20240706060143.GD698153@coredump.intra.peff.net> (Jeff King's message of "Sat, 6 Jul 2024 02:01:43 -0400")

Jeff King <peff@peff.net> writes:

> I'll post some patches in a moment:
>
>   [1/3]: chainlint.pl: fix line number reporting
>   [2/3]: t/chainlint: add test_expect_success call to test snippets
>   [3/3]: t/chainlint: add tests for test body in heredoc
>
> with the idea that we'd apply your patch here on top of what Junio has
> queued in jk/test-body-in-here-doc, and then these three on top.

Would the final form be to have Eric's preparatory enhancement to
chainlint and then these three first, and finally the "here-docs"
conversion I queued from you earlier?


  parent reply	other threads:[~2024-07-06 22:15 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-01 22:08 [PATCH 0/2] here-doc test bodies Jeff King
2024-07-01 22:08 ` [PATCH 1/2] test-lib: allow test snippets as here-docs Jeff King
2024-07-01 22:45   ` Eric Sunshine
2024-07-01 23:43     ` Junio C Hamano
2024-07-02  0:51     ` Jeff King
2024-07-02  1:13       ` Jeff King
2024-07-02 21:37         ` Eric Sunshine
2024-07-06  5:44           ` Jeff King
2024-07-02 21:19       ` Jeff King
2024-07-02 21:59         ` Eric Sunshine
2024-07-06  5:23           ` Jeff King
2024-07-02 21:25       ` Eric Sunshine
2024-07-02 22:36         ` Eric Sunshine
2024-07-02 22:48         ` Eric Sunshine
2024-07-06  5:31         ` Jeff King
2024-07-06  5:33           ` Jeff King
2024-07-06  6:11           ` Eric Sunshine
2024-07-06  6:47             ` Eric Sunshine
2024-07-06  6:55               ` Jeff King
2024-07-06  7:06                 ` Eric Sunshine
2024-07-06  6:54             ` Jeff King
2024-07-01 22:08 ` [PATCH 2/2] t: convert some here-doc test bodies Jeff King
2024-07-02 23:50 ` [PATCH] chainlint.pl: recognize test bodies defined via heredoc Eric Sunshine
2024-07-06  6:01   ` Jeff King
2024-07-06  6:05     ` [PATCH 1/3] chainlint.pl: fix line number reporting Jeff King
2024-07-08  5:08       ` Eric Sunshine
2024-07-08  9:10         ` Jeff King
2024-07-06  6:06     ` [PATCH 2/3] t/chainlint: add test_expect_success call to test snippets Jeff King
2024-07-06  6:09       ` Jeff King
2024-07-08  3:59         ` Eric Sunshine
2024-07-06  6:07     ` [PATCH 3/3] t/chainlint: add tests for test body in heredoc Jeff King
2024-07-08  2:43       ` Eric Sunshine
2024-07-08  8:59         ` Jeff King
2024-07-06 22:15     ` Junio C Hamano [this message]
2024-07-06 23:11       ` [PATCH] chainlint.pl: recognize test bodies defined via heredoc Jeff King
2024-07-08  3:51         ` Eric Sunshine
2024-07-08  9:08           ` Jeff King
2024-07-08 19:46             ` Eric Sunshine
2024-07-08 20:17               ` Eric Sunshine
2024-07-10  0:37                 ` Jeff King
2024-07-10  1:09             ` Jeff King
2024-07-10  3:02               ` Eric Sunshine
2024-07-10  7:06                 ` Jeff King
2024-07-10  7:29                   ` Eric Sunshine
2024-07-08  3:40     ` Eric Sunshine
2024-07-08  9:05       ` Jeff King
2024-07-08 20:06         ` Eric Sunshine
2024-07-10  0:48           ` Jeff King
2024-07-10  2:38             ` Eric Sunshine
2024-07-10  8:34 ` [PATCH v2 0/9] here-doc test bodies (now with 100% more chainlinting) Jeff King
2024-07-10  8:34   ` [PATCH v2 1/9] chainlint.pl: add test_expect_success call to test snippets Jeff King
2024-07-10  8:35   ` [PATCH v2 2/9] chainlint.pl: only start threads if jobs > 1 Jeff King
2024-07-10  8:35   ` [PATCH v2 3/9] chainlint.pl: do not spawn more threads than we have scripts Jeff King
2024-07-10  8:37   ` [PATCH v2 4/9] chainlint.pl: force CRLF conversion when opening input files Jeff King
2024-07-10  8:37   ` [PATCH v2 5/9] chainlint.pl: check line numbers in expected output Jeff King
2024-08-21  7:00     ` Eric Sunshine
2024-08-21 12:14       ` Jeff King
2024-08-21 17:02         ` Eric Sunshine
2024-07-10  8:38   ` [PATCH v2 6/9] chainlint.pl: recognize test bodies defined via heredoc Jeff King
2024-07-10  8:39   ` [PATCH v2 7/9] chainlint.pl: add tests for test body in heredoc Jeff King
2024-07-10  8:39   ` [PATCH v2 8/9] test-lib: allow test snippets as here-docs Jeff King
2024-07-10  8:39   ` [PATCH v2 9/9] t: convert some here-doc test bodies Jeff King
2024-07-10  8:47   ` [PATCH v2 10/9] t/.gitattributes: ignore whitespace in chainlint expect files Jeff King
2024-07-10 17:15     ` Junio C Hamano
2024-08-21  7:31   ` [PATCH v2 0/9] here-doc test bodies (now with 100% more chainlinting) Eric Sunshine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqr0c6makb.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=ericsunshine@charter.net \
    --cc=git@vger.kernel.org \
    --cc=l.s.r@web.de \
    --cc=peff@peff.net \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.