From: Junio C Hamano <gitster@pobox.com>
To: "René Scharfe" <l.s.r@web.de>
Cc: Git List <git@vger.kernel.org>
Subject: Re: PATCH] parse-options: allow omitting option help text
Date: Mon, 28 Aug 2023 08:19:44 -0700 [thread overview]
Message-ID: <xmqqr0nnjisv.fsf@gitster.g> (raw)
In-Reply-To: <2b08dc43-621d-2170-c4a6-c2aac33a9a19@web.de> ("René Scharfe"'s message of "Sat, 26 Aug 2023 10:06:00 +0200")
René Scharfe <l.s.r@web.de> writes:
> 1b68387e02 (builtin/receive-pack.c: use parse_options API, 2016-03-02)
> added the options --stateless-rpc, --advertise-refs and
> --reject-thin-pack-for-testing with a NULL `help` string; 03831ef7b5
> (difftool: implement the functionality in the builtin, 2017-01-19)
> similarly added the "helpless" option --prompt. Presumably this was
> done because all four options are hidden and self-explanatory.
>
> They cause a NULL pointer dereference when using the option --help-all
> with their respective tool, though.
Good find. Will apply. Thanks.
prev parent reply other threads:[~2023-08-28 15:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-26 8:06 PATCH] parse-options: allow omitting option help text René Scharfe
2023-08-28 15:19 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr0nnjisv.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.