All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "Matěj Cepl" <mcepl@cepl.eu>, git@vger.kernel.org
Subject: Re: git-send-email with GPG signed commits?
Date: Thu, 20 Oct 2022 10:48:59 -0700	[thread overview]
Message-ID: <xmqqr0z2s7w4.fsf@gitster.g> (raw)
In-Reply-To: <Y1GJAart+/yFc5MR@coredump.intra.peff.net> (Jeff King's message of "Thu, 20 Oct 2022 13:44:33 -0400")

Jeff King <peff@peff.net> writes:

> So commit signatures are generally an attestation by the committer, not
> by the author. It's just that the two are usually the same when you are
> committing locally.
>
> I think you would need some kind of "author-sig" header that signs the
> commit object bytes _without_ the commit header at all. And that assumes
> the maintainer's workflow is to never modify a patch in transit, and to
> apply it at the exact same spot that you wrote it (so that the parent
> and tree ids remain the same).

Doesn't it immediately break down once you send a 2-patch series?
You may be able to get the bottom one right, but the top one needs
to depend on the commit object name of the result of applying the
bottom one.

It depends on what they are trying to achieve by transferrring with
existing signature intact.  If they truly want to preserve the
validity of the signatures on commits, they are better off
exchanging bundles over e-mail, as reviewers and integrators are not
even allowed to touch anything.

  reply	other threads:[~2022-10-20 17:49 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-20  4:26 git-send-email with GPG signed commits? Matěj Cepl
2022-10-20 12:46 ` Konstantin Ryabitsev
2022-10-20 17:29   ` Matěj Cepl
2022-10-20 18:55     ` Konstantin Ryabitsev
2022-10-20 17:44 ` Jeff King
2022-10-20 17:48   ` Junio C Hamano [this message]
2022-10-20 18:03     ` Junio C Hamano
2022-10-20 18:31       ` Jeff King
2022-10-20 19:01         ` Konstantin Ryabitsev
2022-10-20 19:40           ` rsbecker
2022-10-20 21:03             ` Matěj Cepl
2022-10-20 21:22 ` brian m. carlson
2022-10-21  0:12   ` Matěj Cepl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqr0z2s7w4.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=mcepl@cepl.eu \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.