From: Junio C Hamano <gitster@pobox.com>
To: "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH] shortlog: use a stable sort
Date: Thu, 14 Jul 2022 11:25:05 -0700 [thread overview]
Message-ID: <xmqqr12n5z7i.fsf@gitster.g> (raw)
In-Reply-To: <pull.1290.git.1657813429221.gitgitgadget@gmail.com> (Johannes Schindelin via GitGitGadget's message of "Thu, 14 Jul 2022 15:43:49 +0000")
"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
writes:
> why does our current CI not fail in the vs-test job?". The answer is
> surprisingly trivial: Because our CMake-based definition universally
> defines INTERNAL_QSORT
> [https://github.com/git/git/blob/v2.37.1/contrib/buildsystems/CMakeLists.txt#L227],
> which should actually not even be necessary, while the Azure Pipeline I
> used still calls make vcxproj to generate the Visual Studio build
> definition and does not define that flag.
Diversity in test environments is very good.
prev parent reply other threads:[~2022-07-14 18:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-14 15:43 [PATCH] shortlog: use a stable sort Johannes Schindelin via GitGitGadget
2022-07-14 16:28 ` Junio C Hamano
2022-07-14 18:25 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr12n5z7i.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=johannes.schindelin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.