From: Junio C Hamano <gitster@pobox.com>
To: Fabian Stelzer <fs@gigacodes.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/2] fixup! ssh signing: verify signatures using ssh-keygen
Date: Tue, 12 Oct 2021 10:36:13 -0700 [thread overview]
Message-ID: <xmqqr1cq4036.fsf@gitster.g> (raw)
In-Reply-To: <20211012092236.619822-3-fs@gigacodes.de> (Fabian Stelzer's message of "Tue, 12 Oct 2021 11:22:36 +0200")
Fabian Stelzer <fs@gigacodes.de> writes:
> This behaviour changed during patch review and documentation no longer
> matched it.
> ---
Thanks, you'd need to sign-off, to make this a standalone bugfix
patch.
> Documentation/config/gpg.txt | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/Documentation/config/gpg.txt b/Documentation/config/gpg.txt
> index 51a756b2f1..4f30c7dbdd 100644
> --- a/Documentation/config/gpg.txt
> +++ b/Documentation/config/gpg.txt
> @@ -52,9 +52,7 @@ gpg.ssh.allowedSignersFile::
> SSH has no concept of trust levels like gpg does. To be able to differentiate
> between valid signatures and trusted signatures the trust level of a signature
> verification is set to `fully` when the public key is present in the allowedSignersFile.
> -Therefore to only mark fully trusted keys as verified set gpg.minTrustLevel to `fully`.
> -Otherwise valid but untrusted signatures will still verify but show no principal
> -name of the signer.
> +Otherwise the trust level is `undefined` and git verify-commit/tag will fail.
> +
> This file can be set to a location outside of the repository and every developer
> maintains their own trust store. A central repository server could generate this
next prev parent reply other threads:[~2021-10-12 17:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-12 9:22 [PATCH 0/2] ssh signing: fix merging signed tags & docs Fabian Stelzer
2021-10-12 9:22 ` [PATCH 1/2] ssh signing: fmt-merge-msg tests & config parse Fabian Stelzer
2021-10-12 9:22 ` [PATCH 2/2] fixup! ssh signing: verify signatures using ssh-keygen Fabian Stelzer
2021-10-12 17:36 ` Junio C Hamano [this message]
2021-10-12 17:34 ` [PATCH 0/2] ssh signing: fix merging signed tags & docs Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr1cq4036.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=fs@gigacodes.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.