From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org, Miriam Rubio <mirucam@gmail.com>
Subject: Re: mr/bisect-in-c-4, was Re: What's cooking in git.git (Sep 2021, #02; Wed, 8)
Date: Thu, 09 Sep 2021 22:07:28 -0700 [thread overview]
Message-ID: <xmqqr1dxuigf.fsf@gitster.g> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.2109091308200.59@tvgsbejvaqbjf.bet> (Johannes Schindelin's message of "Thu, 9 Sep 2021 13:08:47 +0200 (CEST)")
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> On Wed, 8 Sep 2021, Junio C Hamano wrote:
>
>> * mr/bisect-in-c-4 (2021-09-02) 6 commits
>> - bisect--helper: retire `--bisect-next-check` subcommand
>> - bisect--helper: reimplement `bisect_run` shell
>> - bisect--helper: reimplement `bisect_visualize()`shell function in C
>> - run-command: make `exists_in_PATH()` non-static
>> - t6030-bisect-porcelain: add test for bisect visualize
>> - t6030-bisect-porcelain: add tests to control bisect run exit cases
>>
>> Rewrite of "git bisect" in C continues.
>
> From my point of view, this is ready for `next`.
You agreed that redirection with dup2()'s in [5/6] was good enough
for now [*1*], but in that case, we need to add a few fflush(stdout)
around the dup2() dance [*2*].
So this is not quite ready for 'next' yet, although it is almost
there, I'd think.
[References]
*1* https://lore.kernel.org/git/nycvar.QRO.7.76.6.2109090922310.55@tvgsbejvaqbjf.bet/
*2* https://lore.kernel.org/git/xmqqtuj2h7cp.fsf@gitster.g/
next prev parent reply other threads:[~2021-09-10 5:07 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-08 15:38 What's cooking in git.git (Sep 2021, #02; Wed, 8) Junio C Hamano
2021-09-08 16:24 ` Taylor Blau
2021-09-08 19:23 ` Junio C Hamano
2021-09-09 1:02 ` Taylor Blau
2021-09-08 21:27 ` Jeff King
2021-09-08 16:55 ` Azeem Bande-Ali
2021-09-08 19:20 ` Junio C Hamano
2021-09-08 17:50 ` Philippe Blain
2021-09-08 21:57 ` Derrick Stolee
2021-09-09 14:23 ` Elijah Newren
2021-09-09 2:59 ` Ramsay Jones
2021-09-09 17:45 ` Junio C Hamano
2021-09-09 11:03 ` js/scalar, was " Johannes Schindelin
2021-09-10 8:52 ` Junio C Hamano
2021-09-09 11:05 ` rs/range-diff-avoid-segfault-with-I, " Johannes Schindelin
2021-09-09 11:08 ` js/retire-preserve-merges, " Johannes Schindelin
2021-09-10 5:00 ` Junio C Hamano
2021-09-09 11:08 ` mr/bisect-in-c-4, " Johannes Schindelin
2021-09-10 5:07 ` Junio C Hamano [this message]
2021-09-10 9:33 ` Johannes Schindelin
2021-09-09 11:13 ` lh/systemd-timers, " Johannes Schindelin
2021-09-09 11:15 ` ar/submodule-add-more, " Johannes Schindelin
2021-09-10 5:30 ` Junio C Hamano
2021-09-09 11:18 ` Ævar Arnfjörð Bjarmason
2021-09-09 14:12 ` Elijah Newren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr1dxuigf.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=mirucam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.