From: Junio C Hamano <gitster@pobox.com>
To: Madhu <enometh@meer.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] init: don't reset core.filemode on git-new-workdirs.
Date: Mon, 22 Mar 2021 23:39:31 -0700 [thread overview]
Message-ID: <xmqqr1k64bmk.fsf@gitster.g> (raw)
In-Reply-To: <20210323.092748.1559327071188512317.enometh@meer.net> (Madhu's message of "Tue, 23 Mar 2021 09:27:48 +0530 (IST)")
Madhu <enometh@meer.net> writes:
> Avoiding the filemode check completely during reinit is ok with me
> because it gave me wrong results. I can't speak for the original
> author of the code - if his intention was to do it explicitly as part
> of "reinitialization".
As the original author of the code, I know I meant filemode check to
be done and redone upon reinitialization in 4f629539 (init-db: check
template and repository format., 2005-11-25).
But then when 75d24499 (git-init: autodetect core.symlinks,
2007-08-31) started to autodetect symbolic link support, I somehow
ended up doing it only upon the repository creation. Later,
2455406a (git-init: autodetect core.ignorecase, 2008-05-11) imitated
to check case sensitivity in the same block, doing it only once.
Either of these two commits would have been a good chance for us to
realize that filemode check should be done the same way, but somehow
nobody noticed X-<.
next prev parent reply other threads:[~2021-03-23 6:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-21 12:28 [PATCH] init: don't reset core.filemode on git-new-workdirs Madhu
2021-03-21 21:58 ` Junio C Hamano
2021-03-22 2:40 ` Madhu
2021-03-22 4:53 ` Junio C Hamano
2021-03-22 9:04 ` Madhu
2021-03-22 18:02 ` Junio C Hamano
2021-03-23 3:57 ` Madhu
2021-03-23 6:39 ` Junio C Hamano [this message]
2021-03-23 16:53 ` Torsten Bögershausen
2021-03-23 17:45 ` Junio C Hamano
2021-03-23 20:31 ` Torsten Bögershausen
2021-03-23 20:50 ` Junio C Hamano
2021-06-18 4:18 ` Madhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr1k64bmk.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=enometh@meer.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.