From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Isaac Shabtay <isaac@shabtay.com>, Jeff King <peff@peff.net>,
git@vger.kernel.org
Subject: Re: Bug report: git clone with dest
Date: Fri, 05 Jan 2018 12:38:13 -0800 [thread overview]
Message-ID: <xmqqr2r4avnu.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.1801052118410.1337@wbunaarf-fpuvaqryva.tvgsbejvaqbjf.bet> (Johannes Schindelin's message of "Fri, 5 Jan 2018 21:22:07 +0100 (STD)")
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> Hi Isaac,
>
> On Fri, 5 Jan 2018, Isaac Shabtay wrote:
>
>> Done: https://github.com/git-for-windows/git/pull/1421
>>
>> I added credit to Jeff in the PR's description.
>
> Sadly, the PR's description won't make it into the commit history, and the
> authorship really should have been retained.
>
> I found Peff's topic branch in his fork and force-pushed, to demonstrate
> what I wanted to have. Currently the test suite is running (I test 64-bit
> builds of the three major platforms Windows, macOS and Linux), and once
> that is done and passed, I will merge the Pull Request.
>
>> Note that I tried compiling master, but failed due to a reason
>> unrelated to this patch:
>>
>> builtin/checkout.c:24:10: fatal error: fscache.h: No such file or directory
>
> That was an oversight in a previously-merged Pull Request. I have fixed
> that locally and will soon push it out onto `master`.
>
> Ciao,
> Johannes
FWIW, I do not mind including this as part of -rc2 if not -rc1 for
the upcoming release.
next prev parent reply other threads:[~2018-01-05 20:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-03 20:59 Bug report: git clone with dest Isaac Shabtay
2018-01-03 22:28 ` Jeff King
2018-01-03 22:44 ` Isaac Shabtay
2018-01-04 23:20 ` Johannes Schindelin
2018-01-05 5:11 ` Isaac Shabtay
2018-01-05 10:33 ` Johannes Schindelin
2018-01-05 18:55 ` Isaac Shabtay
2018-01-05 20:22 ` Johannes Schindelin
2018-01-05 20:38 ` Junio C Hamano [this message]
2018-01-05 20:44 ` Jeff King
2018-01-05 21:39 ` Johannes Schindelin
[not found] ` <CAK2k7nQcY+QQBfda6CHM8tFo3i4XX2tXxHKv73t6SJ4rRvWo1w@mail.gmail.com>
2018-01-04 4:01 ` Jeff King
2018-01-05 19:53 ` Junio C Hamano
2018-01-05 19:57 ` Jeff King
2018-01-05 20:45 ` Junio C Hamano
2018-01-05 20:52 ` Jeff King
2018-01-05 22:37 ` Junio C Hamano
2018-01-06 4:43 ` Jeff King
2018-01-05 21:06 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr2r4avnu.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=isaac@shabtay.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.