From: Junio C Hamano <gitster@pobox.com>
To: Johannes Sixt <j6t@kdbg.org>
Cc: Dan Jacques <dnj@google.com>,
git@vger.kernel.org, Johannes.Schindelin@gmx.de,
avarab@gmail.com
Subject: Re: [PATCH v4 1/4] Makefile: generate Perl header from template file
Date: Sat, 02 Dec 2017 21:26:07 -0800 [thread overview]
Message-ID: <xmqqr2scjsb4.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <3c897f4c-0cb5-ca44-f144-598a623c1dc3@kdbg.org> (Johannes Sixt's message of "Fri, 1 Dec 2017 17:59:46 +0100")
Johannes Sixt <j6t@kdbg.org> writes:
>> + sed -e 's=@@PATHSEP@@=$(pathsep)=g' \
>
> This doesn't work, unfortunately. When $(pathsep) is ';', we get an
> incomplete sed expression because ';' is also a command separator in
> the sed language.
It is correct that ';' can be and does get used in place of LF when
writing a script on a single line, but even then, as part of a
string argument to 's' command (and also others), there is no need
to quote ';' or otherwise treat it any specially, as the commands
know what their syntax is (e.g. 's=string=replacement=' after seeing
the first '=' knows that it needs to find one unquoted '=' to find
the end of the first argument, and another to find the end of the
replacement string, and ';' seen during that scanning would not have
any special meaning).
If your sed is so broken and does not satisfy the above expectation,
t6023 would not work for you, I would gess.
t/t6023-merge-file.sh:sed -e "s/deerit.\$/deerit;/" -e "s/me;\$/me./" < new5.txt > new6.txt
t/t6023-merge-file.sh:sed -e "s/deerit.\$/deerit,/" -e "s/me;\$/me,/" < new5.txt > new7.txt
t/t6023-merge-file.sh:sed -e 's/deerit./&%%%%/' -e "s/locavit,/locavit;/"< new6.txt | tr '%' '\012' > new8.txt
next prev parent reply other threads:[~2017-12-03 5:26 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-29 15:56 [PATCH v4 0/4] RUNTIME_PREFIX relocatable Git Dan Jacques
2017-11-29 15:56 ` [PATCH v4 1/4] Makefile: generate Perl header from template file Dan Jacques
2017-12-01 16:59 ` Johannes Sixt
2017-12-01 17:13 ` Johannes Schindelin
2017-12-01 17:25 ` Johannes Sixt
2017-12-01 18:18 ` Dan Jacques
2017-12-01 18:52 ` Andreas Schwab
2017-12-05 20:54 ` Johannes Sixt
2017-12-05 21:17 ` Junio C Hamano
2017-12-05 21:26 ` Dan Jacques
2017-12-05 21:35 ` Junio C Hamano
2017-12-06 18:25 ` Johannes Sixt
2017-12-06 18:47 ` Junio C Hamano
2017-12-06 18:56 ` Daniel Jacques
2017-12-06 19:01 ` Ævar Arnfjörð Bjarmason
2017-12-08 21:15 ` Ævar Arnfjörð Bjarmason
2018-04-23 23:23 ` [PATCH dj/runtime-prefix 0/2] Handle $IFS in $INSTLIBDIR Jonathan Nieder
2018-04-23 23:24 ` [PATCH 1/2] Makefile: remove unused @@PERLLIBDIR@@ substitution variable Jonathan Nieder
2018-04-24 2:11 ` Junio C Hamano
2018-04-23 23:25 ` [PATCH 2/2] Makefile: quote $INSTLIBDIR when passing it to sed Jonathan Nieder
2018-04-24 0:53 ` Junio C Hamano
2018-04-24 2:18 ` [PATCH 2/2 v2] " Jonathan Nieder
2018-04-24 2:56 ` Daniel Jacques
2017-12-03 5:26 ` Junio C Hamano [this message]
2017-12-03 9:26 ` [PATCH v4 1/4] Makefile: generate Perl header from template file Ævar Arnfjörð Bjarmason
2017-11-29 15:56 ` [PATCH v4 2/4] Makefile: add support for "perllibdir" Dan Jacques
2017-11-29 20:04 ` Ævar Arnfjörð Bjarmason
2017-11-29 15:56 ` [PATCH v4 3/4] Makefile: add Perl runtime prefix support Dan Jacques
2017-11-29 21:00 ` Ævar Arnfjörð Bjarmason
2017-12-02 15:47 ` [PATCH v4 3/4] RUNTIME_PREFIX relocatable Git Dan Jacques
2017-11-29 21:04 ` [PATCH v4 3/4] Makefile: add Perl runtime prefix support Ævar Arnfjörð Bjarmason
2017-11-29 15:56 ` [PATCH v4 4/4] exec_cmd: RUNTIME_PREFIX on some POSIX systems Dan Jacques
2017-11-29 21:12 ` [PATCH v4 0/4] RUNTIME_PREFIX relocatable Git Ævar Arnfjörð Bjarmason
2017-11-29 22:38 ` Dan Jacques
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr2scjsb4.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=avarab@gmail.com \
--cc=dnj@google.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.