All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: Jeff King <peff@peff.net>, GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [RFC PATCH] GIT-VERSION-GEN: set --abbrev=9 to match auto-scaling
Date: Mon, 05 Dec 2016 14:24:57 -0800	[thread overview]
Message-ID: <xmqqr35m2eva.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <e74163ee-e7d4-bcbd-e65f-368bc2ee9a2d@ramsayjones.plus.com> (Ramsay Jones's message of "Mon, 5 Dec 2016 20:30:17 +0000")

Ramsay Jones <ramsay@ramsayjones.plus.com> writes:

> As I said, the original version of the patch just removed the
> --abbrev=7, but then I started to think about why you might have
> used --abbrev in the first place (first in commit 9b88fcef7 and
> again in commit bf505158d). Making sure to override the configuration
> was the only thing I could come up with. So, I was hoping you could
> remember why! :-P

Nope.  As a maintainer support script, the only thing I cared about
it is that there is no -gXXXX at the end for anything I release ;-)

> (I assumed it was to force a measure of uniformity/reproducibility).

You cannot force uniformity/reproducibility with fixed abbrev,
unless you set abbreviation length to 40, so you are correct to add
"a measure of" there ;-) The first choice (i.e. 4) may have had a
justification to force absolute minimum, and the second one (i.e. 7)
may have had a justifiation to make it clear that we are using the
same setting as the default, so in post-1.7.10 era, I think it is
fine for us to just say "we have been using the same as default, so
let's not specify anything explicitly".



  reply	other threads:[~2016-12-05 22:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-04 20:45 [RFC PATCH] GIT-VERSION-GEN: set --abbrev=9 to match auto-scaling Ramsay Jones
2016-12-05  5:32 ` Jeff King
2016-12-05 11:21   ` Ramsay Jones
2016-12-05 18:10     ` Junio C Hamano
2016-12-05 20:30       ` Ramsay Jones
2016-12-05 22:24         ` Junio C Hamano [this message]
2016-12-05 22:42           ` Ramsay Jones
2016-12-05 18:01   ` Junio C Hamano
2016-12-06 14:03     ` Jeff King
2016-12-06 18:17       ` Junio C Hamano
2016-12-06 18:26         ` Jeff King
2016-12-06 20:43           ` Ramsay Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqr35m2eva.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=ramsay@ramsayjones.plus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.