From: Junio C Hamano <gitster@pobox.com>
To: Karthik Nayak <karthik.188@gmail.com>
Cc: git@vger.kernel.org, sunshine@sunshineco.com
Subject: Re: [PATCH v4 00/12] ref-filter: use parsing functions
Date: Mon, 01 Feb 2016 14:25:54 -0800 [thread overview]
Message-ID: <xmqqr3gwt6dp.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <1454262176-6594-1-git-send-email-Karthik.188@gmail.com> (Karthik Nayak's message of "Sun, 31 Jan 2016 23:12:44 +0530")
Karthik Nayak <karthik.188@gmail.com> writes:
> This series cleans up populate_value() in ref-filter, by moving out
> the parsing part of atoms to separate parsing functions. This ensures
> that parsing is only done once and also improves the modularity of the
> code.
>
> v1: http://thread.gmane.org/gmane.comp.version-control.git/281180
> v2: http://thread.gmane.org/gmane.comp.version-control.git/282563
> v3: http://thread.gmane.org/gmane.comp.version-control.git/283350
>
> Changes:
> * The parsing functions now take the arguments of the atom as
> function parameteres, instead of parsing it inside the fucntion.
> * Rebased on top of pu:jk/list-tag-2.7-regression
> * In strbuf use a copylen variable rather than using multiplication
> to perform a logical operation.
> * Code movement for easier review and general improvement.
> * Use COLOR_MAXLEN as the maximum size for the color variable.
> * Small code changes.
> * Documentation changes.
> * Fixed incorrect style of test (t6302).
>
> Karthik Nayak (12):
> strbuf: introduce strbuf_split_str_omit_term()
> ref-filter: use strbuf_split_str_omit_term()
> ref-filter: bump 'used_atom' and related code to the top
> ref-filter: introduce struct used_atom
> ref-filter: introduce parsing functions for each valid atom
> ref-filter: introduce color_atom_parser()
> ref-filter: introduce parse_align_position()
> ref-filter: introduce align_atom_parser()
> ref-filter: align: introduce long-form syntax
> ref-filter: introduce remote_ref_atom_parser()
> ref-filter: introduce contents_atom_parser()
> ref-filter: introduce objectname_atom_parser()
Hmm, 10/12 didn't make it to the list?
next prev parent reply other threads:[~2016-02-01 22:26 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-31 17:42 [PATCH v4 00/12] ref-filter: use parsing functions Karthik Nayak
2016-01-31 17:42 ` [PATCH v4 01/12] strbuf: introduce strbuf_split_str_omit_term() Karthik Nayak
2016-01-31 17:42 ` [PATCH v4 02/12] ref-filter: use strbuf_split_str_omit_term() Karthik Nayak
2016-01-31 17:42 ` [PATCH v4 03/12] ref-filter: bump 'used_atom' and related code to the top Karthik Nayak
2016-02-01 22:22 ` Junio C Hamano
2016-02-02 18:50 ` Karthik Nayak
2016-02-02 18:56 ` Karthik Nayak
2016-01-31 17:42 ` [PATCH v4 04/12] ref-filter: introduce struct used_atom Karthik Nayak
2016-01-31 17:42 ` [PATCH v4 05/12] ref-filter: introduce parsing functions for each valid atom Karthik Nayak
2016-02-03 22:19 ` Eric Sunshine
2016-02-04 1:17 ` Junio C Hamano
2016-02-06 14:36 ` Karthik Nayak
2016-02-07 7:03 ` Eric Sunshine
2016-02-07 9:03 ` Karthik Nayak
2016-02-06 15:15 ` Karthik Nayak
2016-02-07 6:33 ` Eric Sunshine
2016-02-07 9:01 ` Karthik Nayak
2016-02-07 9:12 ` Eric Sunshine
2016-02-07 13:47 ` Andreas Schwab
2016-02-09 17:00 ` Karthik Nayak
2016-01-31 17:42 ` [PATCH v4 06/12] ref-filter: introduce color_atom_parser() Karthik Nayak
2016-02-04 22:25 ` Eric Sunshine
2016-02-06 15:20 ` Karthik Nayak
2016-02-06 15:51 ` Christian Couder
2016-02-07 7:53 ` Eric Sunshine
2016-02-07 7:43 ` Eric Sunshine
2016-02-07 9:04 ` Karthik Nayak
2016-01-31 17:42 ` [PATCH v4 07/12] ref-filter: introduce parse_align_position() Karthik Nayak
2016-01-31 17:42 ` [PATCH v4 08/12] ref-filter: introduce align_atom_parser() Karthik Nayak
2016-02-04 23:48 ` Eric Sunshine
2016-02-06 15:26 ` Karthik Nayak
2016-01-31 17:42 ` [PATCH v4 09/12] ref-filter: align: introduce long-form syntax Karthik Nayak
2016-02-05 0:00 ` Eric Sunshine
2016-02-06 18:37 ` Karthik Nayak
2016-01-31 17:42 ` [PATCH v4 11/12] ref-filter: introduce contents_atom_parser() Karthik Nayak
2016-02-05 0:22 ` Eric Sunshine
2016-02-07 4:58 ` Karthik Nayak
2016-01-31 17:42 ` [PATCH v4 12/12] ref-filter: introduce objectname_atom_parser() Karthik Nayak
2016-02-01 22:25 ` Junio C Hamano [this message]
2016-02-02 0:37 ` [PATCH v4 00/12] ref-filter: use parsing functions Eric Sunshine
2016-02-02 4:35 ` Karthik Nayak
2016-02-05 0:34 ` Eric Sunshine
[not found] ` <1454262176-6594-11-git-send-email-Karthik.188@gmail.com>
2016-02-02 0:59 ` [PATCH v4 10/12] ref-filter: introduce remote_ref_atom_parser() Eric Sunshine
2016-02-02 2:59 ` Karthik Nayak
2016-02-05 0:05 ` Eric Sunshine
2016-02-06 18:44 ` Karthik Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr3gwt6dp.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=karthik.188@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.