All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: James <rouzier@gmail.com>, Git List <git@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] modernize t7300
Date: Mon, 07 Dec 2015 14:50:22 -0800	[thread overview]
Message-ID: <xmqqr3ixlvpt.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CAPig+cQOW69-YNaVvqaVYyNt6cT-u92a=i0V6YufnVEmYHy3LA@mail.gmail.com> (Eric Sunshine's message of "Mon, 7 Dec 2015 17:46:00 -0500")

Eric Sunshine <sunshine@sunshineco.com> writes:

> Alternately, update test_path_foo() functions to accept multiple
> pathnames, or is that too ugly?

That actually would have been my first choice, except (1) that
path_is_missing has a cruft whose usefulness is dubious, and (2)
that "path_exists A B C" and "path_is_missing D E F" would be
gramatically incorrect.

I think we should first see if we can remove that "customized
message" that appears only in path_is_missing and remove it if
we can.  Extending "path_is_missing A B C" and friends to work
would then become trivial.

Thanks.

  reply	other threads:[~2015-12-07 22:50 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-26 14:44 [PATCH] clean: new option --exclude-from James
2015-11-30  2:24 ` Eric Sunshine
     [not found]   ` <CAGjXF72PgdjBw03ERVYxj+atvsBXK0LeJ6O3zTZgi3-kv9BWsw@mail.gmail.com>
2015-12-01 22:25     ` Eric Sunshine
2015-12-06 14:58       ` [PATCH v2 1/2] modernize t7300 James
2015-12-06 14:58         ` [PATCH v2 2/2] clean: new option --exclude-from James
2015-12-07 20:56           ` Jeff King
2015-12-07 21:44           ` Junio C Hamano
2015-12-07 22:53           ` Eric Sunshine
2015-12-07 21:40         ` [PATCH v2 1/2] modernize t7300 Junio C Hamano
2015-12-07 22:46           ` Eric Sunshine
2015-12-07 22:50             ` Junio C Hamano [this message]
2015-12-07 22:43         ` Eric Sunshine
2015-12-02  0:53 ` [PATCH] clean: new option --exclude-from Jeff King
2015-12-02  2:18   ` Junio C Hamano
2015-12-02  2:44     ` Jeff King
2015-12-02 16:40       ` Junio C Hamano
2015-12-02 16:47         ` Jeff King
2015-12-02 17:25           ` Junio C Hamano
2015-12-02 17:51             ` Jeff King
2015-12-06  3:51               ` Junio C Hamano
2015-12-07 19:39                 ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqr3ixlvpt.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=rouzier@gmail.com \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.