From: Junio C Hamano <gitster@pobox.com>
To: Johan Herland <johan@herland.net>
Cc: Git mailing list <git@vger.kernel.org>,
"Kyle J. McKay" <mackyle@gmail.com>,
"James H. Fisher" <jhf@trifork.com>,
Eric Sunshine <sunshine@sunshineco.com>
Subject: Re: [PATCHv3 3/5] builtin/notes: Add --allow-empty, to allow storing empty notes
Date: Mon, 10 Nov 2014 12:18:14 -0800 [thread overview]
Message-ID: <xmqqr3xa95dl.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CALKQrgdFDHUc8JzH3XnwvnHdEZOhUN=EmrWXKKDLd+6MG7jMKw@mail.gmail.com> (Johan Herland's message of "Sun, 9 Nov 2014 13:31:32 +0100")
Johan Herland <johan@herland.net> writes:
> On Fri, Nov 7, 2014 at 7:04 PM, Junio C Hamano <gitster@pobox.com> wrote:
>
>> In other words, I have this suspicion that create_note() that
>> removes is a wrong interface in the first place, and giving it
>> a new allow_empty parameter to conditionally perform removal is
>> making it worse. No?
>
> I agree, and it's fixed in the re-roll. It turned into a slightly
> larger rewrite than anticipated, but I'm fairly happy with the result.
;-)
next prev parent reply other threads:[~2014-11-10 20:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-07 9:19 [PATCHv3 0/5] Handling empty notes Johan Herland
2014-11-07 9:19 ` [PATCHv3 1/5] builtin/notes: Fix premature failure when trying to add the empty blob Johan Herland
2014-11-07 9:19 ` [PATCHv3 2/5] t3301: Verify that 'git notes' removes empty notes by default Johan Herland
2014-11-07 17:48 ` Junio C Hamano
2014-11-07 9:19 ` [PATCHv3 3/5] builtin/notes: Add --allow-empty, to allow storing empty notes Johan Herland
2014-11-07 18:04 ` Junio C Hamano
2014-11-09 12:31 ` Johan Herland
2014-11-10 20:18 ` Junio C Hamano [this message]
2014-11-07 9:19 ` [PATCHv3 4/5] notes: Empty notes should be shown by 'git log' Johan Herland
2014-11-07 18:51 ` Junio C Hamano
2014-11-07 9:19 ` [PATCHv3 5/5] t3301: Use write_script(), nitpick whitespace Johan Herland
2014-11-07 18:55 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr3xa95dl.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jhf@trifork.com \
--cc=johan@herland.net \
--cc=mackyle@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.