From: Junio C Hamano <gitster@pobox.com>
To: Martin Langhoff <martin.langhoff@gmail.com>
Cc: Jeff King <peff@peff.net>, Martin Fick <mfick@codeaurora.org>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: Diagnosing stray/stale .keep files -- explore what is in a pack?
Date: Wed, 15 Jan 2014 09:49:05 -0800 [thread overview]
Message-ID: <xmqqr4892l0u.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CACPiFCKeOYHUb22d_Ea0PcbU-uAn=fVAn0QP1qbLAiNh1KEoqQ@mail.gmail.com> (Martin Langhoff's message of "Wed, 15 Jan 2014 08:42:26 -0500")
Martin Langhoff <martin.langhoff@gmail.com> writes:
> On Wed, Jan 15, 2014 at 4:12 AM, Jeff King <peff@peff.net> wrote:
>> We see these occasionally at GitHub, too. I haven't yet figured out a
>> definite cause, though whatever it is, it's relatively rare.
>
> Do you have a cleanup script to safely get rid of stale .keep and
> .lock files? I wonder what other stale bits merit a cleanup...
As long as we can reliably determine that it is safe to do so
without risking races, automatically cleaning .lock files is a good
thing to do.
Cleaning .keep files needs the same care and a bit more, though.
You of course have to be sure that no other concurrent process is in
the middle of doing something, but you also need to be sure that the
".keep" file is not a marker created by the end user to say "keep
this pack, do not subject its contents to repacking" after a careful
repacking of the stable part of the history.
next prev parent reply other threads:[~2014-01-15 17:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-14 14:54 Diagnosing stray/stale .keep files -- explore what is in a pack? Martin Langhoff
2014-01-14 17:10 ` Martin Langhoff
2014-01-14 19:36 ` Martin Fick
2014-01-14 19:42 ` Martin Langhoff
2014-01-15 9:12 ` Jeff King
2014-01-15 13:42 ` Martin Langhoff
2014-01-15 17:49 ` Junio C Hamano [this message]
2014-01-15 23:50 ` Martin Langhoff
2014-01-16 1:14 ` Duy Nguyen
2014-01-21 5:19 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr4892l0u.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=martin.langhoff@gmail.com \
--cc=mfick@codeaurora.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.