All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Hussain Sitamouwala <husainsitamuwala21@gmail.com>
Cc: git@vger.kernel.org,  christian.couder@gmail.com
Subject: Re: [PATCH v2] doc: describe promisor remote fetch order
Date: Sun, 08 Nov 2026 11:03:06 -0800	[thread overview]
Message-ID: <xmqqse1b2ljp.fsf@gitster.g> (raw)
In-Reply-To: <20261108071933.6586-1-husainsitamuwala21@gmail.com> (Hussain Sitamouwala's message of "Sun, 8 Nov 2026 07:19:33 +0000")

Hussain Sitamouwala <husainsitamuwala21@gmail.com> writes:

> Explain that promisor remotes accepted from a server are tried
> before other promisor remotes, and that the remaining objects are
> requested from the next remote when a fetch fails. The ordering
> was introduced by 8808e61fd3 (promisor-remote: try accepted
> remotes before others in get_direct(), 2026-04-07).

Well written.  "next" sounded a bit strange thing to say in the
context, but it was understandable.

Assuming that I understood what the author wanted to say correctly,
that is ;-), so let's double-check.  Would it mean the same thing if
we replace "next remote" with "other promisor remotes"?

>  Documentation/technical/partial-clone.adoc | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/technical/partial-clone.adoc b/Documentation/technical/partial-clone.adoc
> index 18718a3840..efe9acac65 100644
> --- a/Documentation/technical/partial-clone.adoc
> +++ b/Documentation/technical/partial-clone.adoc
> @@ -195,7 +195,10 @@ cache servers for fetching missing blobs while continuing to do
>  filtered `git-fetch` commands from the central server.
>  
>  When fetching objects, promisor remotes are tried one after the other
> -until all the objects have been fetched.
> +until all the objects have been fetched. Promisor remotes that the
> +client accepted from a server's advertisement are tried before the
> +other promisor remotes. If a fetch from a remote fails, the objects
> +that are still missing are requested from the next remote.

The same comment on "next" here.

  parent reply	other threads:[~2026-11-08 19:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-08  7:19 [PATCH v2] doc: describe promisor remote fetch order Hussain Sitamouwala
2026-11-08 18:45 ` Junio C Hamano
2026-11-08 19:07   ` Hussain Sitamouwala
2026-11-08 19:03 ` Junio C Hamano [this message]
2026-11-08 19:12   ` Hussain Sitamouwala
2026-11-08 19:16   ` Junio C Hamano
2026-11-08 19:22     ` Hussain Sitamouwala
2026-11-09 15:45       ` Junio C Hamano
2026-11-10 12:58         ` Hussain Sitamouwala
2026-11-08 21:38     ` [PATCH] environment: move assume_unchanged into repo_config_values Hussain Sitamouwala
2026-11-08 19:55 ` [PATCH v3] doc: describe promisor remote fetch order Hussain Sitamouwala
2026-11-09  5:09   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqse1b2ljp.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=husainsitamuwala21@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.