From: Junio C Hamano <gitster@pobox.com>
To: Harald Nordgren <haraldnordgren@gmail.com>
Cc: Harald Nordgren via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH] range-diff: add --matched-only to skip one-sided commits
Date: Fri, 11 Sep 2026 11:52:40 -0700 [thread overview]
Message-ID: <xmqqse3faadj.fsf@gitster.g> (raw)
In-Reply-To: <CAHwyqnWkEaQHsp5GtYGL9qg-FYA0Ngt_+omdh8jmw4KfqfX6Uw@mail.gmail.com> (Harald Nordgren's message of "Fri, 11 Sep 2026 20:48:45 +0200")
Harald Nordgren <haraldnordgren@gmail.com> writes:
>> I wonder if the implementation actually can be more like
>>
>> - give "--hide-left-only" and "--hide-right-only" as synonyms to
>> "--right-only" and "--left-only", and deprecate the original;
>>
>> - allow them to be given together, which will give the new
>> behaviour you are introducing, i.e., skip steps without both
>> sides from the output;
>>
>> - give a short-hand synonym, "--matched-only", to truly behave the
>> same as giving "--hide-{left,right}-only" together.
>
> Seems like a big change, and deprecated options are a pain in the neck
> because we can never actually remove them.
>
> If we decide to go this way, we might name them "--hide-{left,right}"
> and just not introduce a condition that makes them incompatible. Then
> "--matched-only" would be pure syntactic sugar and wouldn't even be
> 100% necessary to have to achieve this.
Or we can just keep the code and fix the documentation. I think
that would be much less impact.
next prev parent reply other threads:[~2026-09-11 18:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-11 16:41 [PATCH] range-diff: add --matched-only to skip one-sided commits Harald Nordgren via GitGitGadget
2026-09-11 17:19 ` Junio C Hamano
2026-09-11 18:48 ` Harald Nordgren
2026-09-11 18:52 ` Junio C Hamano [this message]
2026-09-11 19:01 ` Harald Nordgren
2026-09-11 19:05 ` Junio C Hamano
2026-09-11 20:55 ` [PATCH v2] " Harald Nordgren via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqse3faadj.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=haraldnordgren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.