All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Hendrik Jaeger <ml_git@henk.geekmail.org>,  git@vger.kernel.org
Subject: Re: git config: unintuitive behaviour with --global and --no-includes
Date: Mon, 20 Jul 2026 10:09:04 -0700	[thread overview]
Message-ID: <xmqqse5dd1vz.fsf@gitster.g> (raw)
In-Reply-To: <20260720125145.GA5100@coredump.intra.peff.net> (Jeff King's message of "Mon, 20 Jul 2026 08:51:45 -0400")

Jeff King <peff@peff.net> writes:

> IMHO lbmk is wrong to be using "--global" in the first place. Looking at
> the source, it is trying to check whether the user has set up their
> identity. But it is not lbmk's business whether you did it in the
> --global config file, or elsewhere!

Exactly.

> Though note there is one other hitch, which is that the user can set
> author.* and committer.* as specific variables, since 39ab4d0951
> (config: allow giving separate author and committer idents, 2019-02-04).
> I suspect not many people do that, but that would also be something that
> a config-specific check would have to handle (but "git var" would do
> automatically).
>
> So I think you might consider sending a bug report to lbmk. Feel free to
> point at this thread, and I'm happy to discuss further with them.

Thanks for your thoughtful and thorough explanation.

The environment variables 'GIT_{AUTHOR,COMMITTER}_{NAME,EMAIL}' also
play a part in determining the author andcommitter identities, so
'git var AUTHOR_IDENT' would be the correct choice here.



      reply	other threads:[~2026-07-20 17:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-20  9:34 git config: unintuitive behaviour with --global and --no-includes Hendrik Jaeger
2026-07-20 12:25 ` Ben Knoble
2026-07-20 12:51 ` Jeff King
2026-07-20 17:09   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqse5dd1vz.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=ml_git@henk.geekmail.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.