From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] .gitattributes: remove misspelled no-op whitespace attribute
Date: Tue, 11 Nov 2025 14:02:25 -0800 [thread overview]
Message-ID: <xmqqseekut1q.fsf@gitster.g> (raw)
In-Reply-To: <20251111213910.GB4053071@coredump.intra.peff.net> (Jeff King's message of "Tue, 11 Nov 2025 16:39:10 -0500")
Jeff King <peff@peff.net> writes:
> On Tue, Nov 11, 2025 at 10:41:20AM -0800, Junio C Hamano wrote:
>
>> We could either remove "!indent", or spell it "-indent". The
>> immediate effect would be the same. It would only start to make a
>> difference when/if we enable indent-with-non-tab by default in
>> future versions of Git.
>>
>> Let's take the former option to remove "!indent" from the list. We
>> would feel the effect first-hand ourselves before anybody else if we
>> ever decide to change the built-in default whitespace rules, which
>> would be hidden from us if we decide to rewrite it to "-indent"
>> instead.
>
> Perfectly explained, and the result makes sense.
>
> I don't know that this patch particularly needed review, but maybe it is
> nice for you to know that somebody really is out there reading them. ;)
It is mostly a principle thing. I want to see that every non-merge
changes authored by me is treated just like patches authored by
others.
Another reason for me to send these patches out is so that I have a
copy of the patch on the lore archive, with message-ID, so that "git
log --notes=amlog" would work for my changes the same way as anybody
else's.
prev parent reply other threads:[~2025-11-11 22:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-11 18:41 [PATCH] .gitattributes: remove misspelled no-op whitespace attribute Junio C Hamano
2025-11-11 21:39 ` Jeff King
2025-11-11 22:02 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqseekut1q.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.