All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Phillip Wood <phillip.wood123@gmail.com>
Cc: Li Chen <me@linux.beauty>,  git <git@vger.kernel.org>
Subject: Re: [RFC PATCH 1/2] rebase, am: add --reviewby option
Date: Wed, 07 May 2025 10:39:22 -0700	[thread overview]
Message-ID: <xmqqselgcoc5.fsf@gitster.g> (raw)
In-Reply-To: <48b86c85-bc39-40ba-a2b3-67de707dd798@crinan.ddns.net> (Phillip Wood's message of "Wed, 7 May 2025 11:17:33 +0100")

Phillip Wood <phillip.wood123@gmail.com> writes:

> .... The existence and implementation of
> --signoff is largely a historical artifact - I'm not sure we'd make
> the same choices if we were thinking about adding it today.

Very well said.

> I'll take a proper look at the second patch tomorrow.

Thanks.

  parent reply	other threads:[~2025-05-07 17:39 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-06 12:57 [RFC PATCH 0/2] rebase: support --trailer and add --reviewby Li Chen
2025-05-06 12:58 ` [RFC PATCH 1/2] rebase, am: add --reviewby option Li Chen
2025-05-06 18:07   ` Junio C Hamano
2025-05-07  6:46     ` Li Chen
2025-05-07 10:17       ` Phillip Wood
2025-05-07 10:26         ` Phillip Wood
2025-05-07 10:39           ` Kristoffer Haugsbakk
2025-05-07 13:38             ` Phillip Wood
2025-05-07 17:39         ` Junio C Hamano [this message]
2025-05-06 12:58 ` [RFC PATCH 2/2] rebase: support --trailer Li Chen
2025-05-08 14:17   ` Phillip Wood
2025-05-08 15:55     ` Li Chen
2025-05-08 15:58       ` phillip.wood123
2025-05-08 16:29       ` Phillip Wood
2025-05-16  5:42     ` Li Chen
2025-05-16 10:04       ` Phillip Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqselgcoc5.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=me@linux.beauty \
    --cc=phillip.wood123@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.