From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Kyle Lippincott <spectral@google.com>, git@vger.kernel.org
Subject: Re: [PATCH 2/3] ci: avoid bare "gcc" for osx-gcc job
Date: Fri, 10 May 2024 15:47:39 -0700 [thread overview]
Message-ID: <xmqqseyp1dys.fsf@gitster.g> (raw)
In-Reply-To: <20240510220228.GA1962678@coredump.intra.peff.net> (Jeff King's message of "Fri, 10 May 2024 18:02:28 -0400")
Jeff King <peff@peff.net> writes:
> I do think there's value in testing with both clang and gcc in
> general[1]. And there is _some_ code which is compiled only on macos
> and not elsewhere. So this would be our only chance for gcc to see it.
> But it seems like a pretty small return for an entire parallel job.
> Especially as I do not think it has uncovered anything interesting in
> the past (even when it was working).
100% agreed.
> [1] Another quirk is that we run the whole test suite for both
> compilers, which is probably overkill. The main value in comparing
> gcc vs clang is that we don't use any constructs that the compiler
> complains about. It's _possible_ for there to be a construct that
> the compiler does not notice but which causes a runtime difference
> (say, undefined behavior which happens to work out on one compiler),
> but I think we're again hitting diminishing returns.
Yeah, that is a very good point.
next prev parent reply other threads:[~2024-05-10 22:47 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-09 16:22 [PATCH 0/3] un-breaking osx-gcc ci job Jeff King
2024-05-09 16:23 ` [PATCH 1/3] ci: drop mention of BREW_INSTALL_PACKAGES variable Jeff King
2024-05-09 16:24 ` [PATCH 2/3] ci: avoid bare "gcc" for osx-gcc job Jeff King
2024-05-10 7:00 ` Patrick Steinhardt
2024-05-10 20:16 ` Jeff King
2024-05-10 20:32 ` Kyle Lippincott
2024-05-10 20:48 ` Junio C Hamano
2024-05-10 22:02 ` Jeff King
2024-05-10 22:47 ` Junio C Hamano [this message]
2024-05-11 17:21 ` Patrick Steinhardt
2024-05-16 7:19 ` Jeff King
2024-05-16 7:27 ` Jeff King
2024-05-16 9:54 ` Patrick Steinhardt
2024-05-17 8:19 ` Jeff King
2024-05-17 8:33 ` Patrick Steinhardt
2024-05-17 16:59 ` Junio C Hamano
2024-05-23 9:10 ` Jeff King
2024-05-23 15:35 ` Junio C Hamano
2024-05-09 16:25 ` [PATCH 3/3] ci: stop installing "gcc-13" for osx-gcc Jeff King
2024-05-10 7:00 ` Patrick Steinhardt
2024-05-10 20:13 ` Jeff King
2024-05-11 7:17 ` Patrick Steinhardt
2024-05-16 12:36 ` Patrick Steinhardt
2024-05-17 8:11 ` Jeff King
2024-05-17 8:25 ` Patrick Steinhardt
2024-05-17 11:30 ` Patrick Steinhardt
2024-05-26 6:34 ` Philip
2024-05-26 19:23 ` Junio C Hamano
2024-05-27 5:12 ` Patrick Steinhardt
2024-05-29 9:27 ` Jeff King
2024-05-09 16:52 ` [PATCH 0/3] un-breaking osx-gcc ci job Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqseyp1dys.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=spectral@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.