All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: git@vger.kernel.org,  Derrick Stolee <stolee@gmail.com>
Subject: Re: [PATCH] do not set GIT_TEST_MAINT_SCHEDULER where it does not matter
Date: Thu, 28 Mar 2024 22:38:32 -0700	[thread overview]
Message-ID: <xmqqsf09vbqf.fsf@gitster.g> (raw)
In-Reply-To: <CAPig+cStHRX-wZKwdcO33wCjd4UU3MO-rVisyOFZ1vPbGaN51Q@mail.gmail.com> (Eric Sunshine's message of "Thu, 28 Mar 2024 22:43:48 -0400")

Eric Sunshine <sunshine@sunshineco.com> writes:

> Clearly the idea was to protect the scheduler-configuration of the
> person running the test in the event that the test author forgot to
> set GIT_TEST_MAINT_SCHEDULER to one of the legitimate "testing values"
> before invoking a "destructive" command, such as `git maintenance
> start`. By defaulting to `none:exit 1`, the problem would be caught
> and reported before any damage could be done to the configuration of
> the person running the tests.

Yeah, if the variable were exported.  So I am OK with a fix in the
opposite direction.


  reply	other threads:[~2024-03-29  5:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-29  0:51 [PATCH] do not set GIT_TEST_MAINT_SCHEDULER where it does not matter Junio C Hamano
2024-03-29  2:43 ` Eric Sunshine
2024-03-29  5:38   ` Junio C Hamano [this message]
2024-03-29 22:27 ` [PATCH] test-lib: fix non-functioning GIT_TEST_MAINT_SCHEDULER fallback Eric Sunshine
2024-03-31  6:51   ` Eric Sunshine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqsf09vbqf.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=stolee@gmail.com \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.