All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Chris Torek <chris.torek@gmail.com>
Cc: Philippe Blain <levraiphilippeblain@gmail.com>,
	 Philippe Blain via GitGitGadget <gitgitgadget@gmail.com>,
	 git@vger.kernel.org
Subject: Re: [PATCH] t/README: mention test files are make targets
Date: Mon, 25 Mar 2024 12:01:44 -0700	[thread overview]
Message-ID: <xmqqsf0ejftz.fsf@gitster.g> (raw)
In-Reply-To: <CAPx1GvcPEeC3HTdb4bUYASz-t=a7Z2MEUamB4QyO44y4MRy6Pw@mail.gmail.com> (Chris Torek's message of "Mon, 25 Mar 2024 02:59:15 -0700")

Chris Torek <chris.torek@gmail.com> writes:

> On Mon, Mar 25, 2024 at 2:49 AM Junio C Hamano <gitster@pobox.com> wrote:
>> As long as we do not use these $(T) files as an input to some other
>> thing and list them as the dependencies, we are OK, though.
>
> You could (maybe later / at need) stop listing them as `.PHONY` and
> instead use:
>
>     $(T)::
>         sh -c ./$@
>
> or similar, so that some $(T) *can* be an input. Note that this requires
> using double-colon rules earlier to build the test.
>
> I wouldn't do this without a pretty strong reason though.

Me neither.

I personally think a target that is marked as .PHONY and does not
use double-colon rule is a bug by itself but that is a separate
story.

In any case, just to avoid leaving the thread hanging, I'll take the
patch as is, as it documents a useful trick in the status quo.

Thanks, all.

      reply	other threads:[~2024-03-25 19:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-24 15:14 [PATCH] t/README: mention test files are make targets Philippe Blain via GitGitGadget
2024-03-24 16:10 ` Junio C Hamano
2024-03-24 17:04   ` Philippe Blain
2024-03-25  1:24     ` Junio C Hamano
2024-03-25  9:59       ` Chris Torek
2024-03-25 19:01         ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqsf0ejftz.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=chris.torek@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=levraiphilippeblain@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.