All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Toon Claes <toon@iotcl.com>
Cc: Patrick Steinhardt <ps@pks.im>,
	 Eric Sunshine <sunshine@sunshineco.com>,
	 git@vger.kernel.org
Subject: Re: [PATCH 1/1] builtin/show-ref: treat directory directory as non-existing in --exists
Date: Thu, 18 Jan 2024 11:19:09 -0800	[thread overview]
Message-ID: <xmqqsf2uqwk2.fsf@gitster.g> (raw)
In-Reply-To: <87le8nqc73.fsf@iotcl.com> (Toon Claes's message of "Thu, 18 Jan 2024 09:24:56 +0100")

Toon Claes <toon@iotcl.com> writes:

> Junio C Hamano <gitster@pobox.com> writes:
>
>> Yup.  The patch looks good.  Here is what I tentatively queued.
>>
>> ----- >8 -----
>> From: Toon Claes <toon@iotcl.com>
>> Date: Wed, 10 Jan 2024 15:15:59 +0100
>> Subject: [PATCH] builtin/show-ref: treat directory directory as non-existing
>>  in --exists
>
> You have a duplicate "directory" here.

Yikes.  I did notice a breakage in somebody's mailer that inserted a
SP after the first dash in "--exists" and fixed it, but did not
notice you had "directory" duplicated there.  Thanks for noticing.

Amended.  Let's merge it down to 'next'.

Thanks.

      reply	other threads:[~2024-01-18 19:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-10 14:15 [PATCH 0/1] Fix error message in git-show-ref(1) --exists Toon Claes
2024-01-10 14:15 ` [PATCH 1/1] builtin/show-ref: treat directory directory as non-existing in --exists Toon Claes
2024-01-10 14:36   ` Eric Sunshine
2024-01-10 15:20     ` Toon Claes
2024-01-17  6:29       ` Patrick Steinhardt
2024-01-17 23:07         ` Junio C Hamano
2024-01-18  8:24           ` Toon Claes
2024-01-18 19:19             ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqsf2uqwk2.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=ps@pks.im \
    --cc=sunshine@sunshineco.com \
    --cc=toon@iotcl.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.