From: Junio C Hamano <gitster@pobox.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: <git@vger.kernel.org>, Taylor Blau <me@ttaylorr.com>,
Jason Hatton <jhatton@globalfinishing.com>
Subject: Re: [PATCH v2 1/2] t: add a test helper to truncate files
Date: Thu, 12 Oct 2023 15:52:59 -0700 [thread overview]
Message-ID: <xmqqsf6f312s.fsf@gitster.g> (raw)
In-Reply-To: <20231012160930.330618-2-sandals@crustytoothpaste.net> (brian m. carlson's message of "Thu, 12 Oct 2023 16:09:29 +0000")
"brian m. carlson" <sandals@crustytoothpaste.net> writes:
> + fd = open(argv[1], O_WRONLY | O_CREAT, 0600);
> + if (fd < 0)
> + die_errno("failed to open file %s", argv[1]);
contrib/coccinelle/xopen.cocci tells us to write this simply as
fd = xopen(argv[1], O_WRONLY | O_CREAT, 0600);
https://github.com/git/git/actions/runs/6500777388/job/17656837393#step:4:657
next prev parent reply other threads:[~2023-10-12 22:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-12 16:09 [PATCH v2 0/2] Prevent re-reading 4 GiB files on every status brian m. carlson
2023-10-12 16:09 ` [PATCH v2 1/2] t: add a test helper to truncate files brian m. carlson
2023-10-12 17:49 ` Eric Sunshine
2023-10-13 20:23 ` brian m. carlson
2023-10-12 22:52 ` Junio C Hamano [this message]
2023-10-13 20:18 ` brian m. carlson
2023-10-13 20:32 ` Junio C Hamano
2023-10-16 23:53 ` Jeff King
2023-10-12 16:09 ` [PATCH v2 2/2] Prevent git from rehashing 4GiB files brian m. carlson
2023-10-12 17:58 ` Junio C Hamano
2023-10-12 21:58 ` brian m. carlson
2023-10-12 22:11 ` Junio C Hamano
2023-10-17 0:00 ` Jeff King
2023-10-17 14:49 ` Jason Hatton
2023-10-17 17:02 ` Junio C Hamano
2023-10-18 0:42 ` brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqsf6f312s.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jhatton@globalfinishing.com \
--cc=me@ttaylorr.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.