All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Josh Soref <jsoref@gmail.com>
Cc: Josh Soref via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org
Subject: Re: [PATCH] pretty-formats.txt: fix whitespace
Date: Mon, 25 Sep 2023 10:24:07 -0700	[thread overview]
Message-ID: <xmqqsf72upxk.fsf@gitster.g> (raw)
In-Reply-To: <CACZqfqCVsv-ZaSRWt_ejMn5f_U_1E2h7wsCgUg_50A+KHzOgkA@mail.gmail.com> (Josh Soref's message of "Sun, 24 Sep 2023 06:31:46 -0400")

Josh Soref <jsoref@gmail.com> writes:

>> > * comma after `etc.` when not ending a sentence
>>
>> There is one instance that says "A, B, C, D, etc., are all accepted."
>> without the comma after 'etc.' and the patch corrects it.  OK.
>
> It seems like this is the only change that's of interest.
>
> Do I just make a distinct gitgitgadget PR with that change, or do I
> ask it to mark that single change as a V2 to this? (given the branch
> name assumed whitespace and the only change would be a comma, it'd be
> kinda wrong...)

;-)

Up to you.  If I were doing this patch, I would wait and see if
others chime in (to support other changes in v1 that I was on the
negative side) and then make v2 with the changes you still believe
in when that happens.

Thanks.

  reply	other threads:[~2023-09-25 17:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-22 14:10 [PATCH] pretty-formats.txt: fix whitespace Josh Soref via GitGitGadget
2023-09-22 21:56 ` Junio C Hamano
2023-09-24 10:31   ` Josh Soref
2023-09-25 17:24     ` Junio C Hamano [this message]
2023-09-26 18:52     ` Linus Arver
2023-09-26 19:51       ` Josh Soref
2023-09-26 21:20         ` Linus Arver
2023-09-25 20:04 ` Kristoffer Haugsbakk
2023-09-26  2:51   ` Josh Soref
2023-09-26 16:42     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqsf72upxk.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=jsoref@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.