All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Phillip Wood <phillip.wood123@gmail.com>
Cc: Phillip Wood via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org, Jeff King <peff@peff.net>,
	Phillip Wood <phillip.wood@dunelm.org.uk>
Subject: Re: [PATCH] t4053: avoid race when killing background processes
Date: Fri, 11 Aug 2023 08:47:27 -0700	[thread overview]
Message-ID: <xmqqsf8poa28.fsf@gitster.g> (raw)
In-Reply-To: <2d9e9b59-bf78-8470-0731-3cd7fe15a727@gmail.com> (Phillip Wood's message of "Fri, 11 Aug 2023 10:56:40 +0100")

Phillip Wood <phillip.wood123@gmail.com> writes:

> On 10/08/2023 18:40, Junio C Hamano wrote:
>> "Phillip Wood via GitGitGadget" <gitgitgadget@gmail.com> writes:
>>
>> While I can see that "kill" in the when-finished handler may or may
>> not find the backgrounded process by the time it is run, and
>> ignoring its exit status (hence keeping test_when_finished happy)
>> would be a reasonable thing to do.  I can understand if this patch
>> is to fix a different symptom, namely, when-finished handler
>> sometimes fails and makes the test fail.
>> But I am not sure how this causes the test to "hang", 
>
>
> This is only a fix for the test failure that Peff saw when running
> with --stress.

Ah, OK.  I obviously misread the proposed commit log message.  And
as a race-fix, this would be good.

Thanks.

      parent reply	other threads:[~2023-08-11 15:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-10 14:33 [PATCH] t4053: avoid race when killing background processes Phillip Wood via GitGitGadget
2023-08-10 17:40 ` Junio C Hamano
2023-08-11  9:56   ` Phillip Wood
2023-08-11 14:44     ` Jeff King
2023-08-11 15:47     ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqsf8poa28.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=peff@peff.net \
    --cc=phillip.wood123@gmail.com \
    --cc=phillip.wood@dunelm.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.