All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: ZheNing Hu <adlternative@gmail.com>
Cc: "ZheNing Hu via GitGitGadget" <gitgitgadget@gmail.com>,
	git@vger.kernel.org, "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"Zeger-Jan van de Weg" <zegerjan@gitlab.com>
Subject: Re: [PATCH] [RFC] transport: add --show-service option
Date: Wed, 26 Apr 2023 22:50:12 -0700	[thread overview]
Message-ID: <xmqqsfclnaaz.fsf@gitster.g> (raw)
In-Reply-To: <CAOLTT8Qmo31YExXUOPk2sx73b734wuxiD3AUX0UAnPo9WSqpfQ@mail.gmail.com> (ZheNing Hu's message of "Thu, 27 Apr 2023 12:35:23 +0800")

ZheNing Hu <adlternative@gmail.com> writes:

>> The above is a very well written description of why we _can_ do
>> this, but it is unclear why we would _want_ to do this.  What do we
>> gain by letting the individual services to declare "we are serving
>> this!"?  Do we lose an extra fork & process (it does not seem to be
>> the case)?
>
> When I was implementing a small git http server, I wanted to delegate
> everything to upload-pack and receive-pack. Everything else was fine,
> the only thing I was not satisfied with was the need to send an additional
> "#service=$servername" message when the protocol is v1.

I think you had a brief mention on that after the three-dash separator;
it *is* a relevant piece of information that needs to be in the
proposed log message.

Thanks.

  reply	other threads:[~2023-04-27  5:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-24 13:17 [PATCH] [RFC] transport: add --show-service option ZheNing Hu via GitGitGadget
2023-04-25  4:02 ` Junio C Hamano
2023-04-27  4:35   ` ZheNing Hu
2023-04-27  5:50     ` Junio C Hamano [this message]
2023-05-04 15:28 ` [PATCH v2] " ZheNing Hu via GitGitGadget
2023-05-10  8:15   ` ZheNing Hu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqsfclnaaz.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=adlternative@gmail.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=zegerjan@gitlab.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.