From: Junio C Hamano <gitster@pobox.com>
To: "Fangyi Zhou via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, "Fangyi Zhou" <me@fangyi.io>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH] help: reword explanation line for developer interfaces
Date: Fri, 16 Sep 2022 09:19:17 -0700 [thread overview]
Message-ID: <xmqqsfkri96i.fsf@gitster.g> (raw)
In-Reply-To: <pull.1330.git.git.1663333529294.gitgitgadget@gmail.com> (Fangyi Zhou via GitGitGadget's message of "Fri, 16 Sep 2022 13:05:29 +0000")
"Fangyi Zhou via GitGitGadget" <gitgitgadget@gmail.com> writes:
> From: Fangyi Zhou <me@fangyi.io>
>
> Signed-off-by: Fangyi Zhou <me@fangyi.io>
> ---
> help: reword explanation line for developer interfaces
>
> Signed-off-by: Fangyi Zhou me@fangyi.io
> - { CAT_developerinterfaces, N_("Developer-facing file file formats, protocols and interfaces") },
> + { CAT_developerinterfaces, N_("Developer-facing file formats, protocols and other interfaces") },
Yuck. Thanks for catching this.
> { 0, NULL }
> };
>
> diff --git a/t/t0012-help.sh b/t/t0012-help.sh
> index 4ed2f242eb2..dbfc5c82676 100755
> --- a/t/t0012-help.sh
> +++ b/t/t0012-help.sh
> @@ -231,7 +231,7 @@ test_expect_success "'git help -a' section spacing" '
>
> User-facing repository, command and file interfaces
>
> - Developer-facing file file formats, protocols and interfaces
> + Developer-facing file formats, protocols and other interfaces
> EOF
Apparently the writer of the test was not doing a good job; and of
course the reviewers, too X-.
These all came from 844739ba (git docs: add a category for file
formats, protocols and interfaces, 2022-08-04), as a part of a
large series.
Will queue.
prev parent reply other threads:[~2022-09-16 16:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 13:05 [PATCH] help: reword explanation line for developer interfaces Fangyi Zhou via GitGitGadget
2022-09-16 16:19 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqsfkri96i.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=me@fangyi.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.