From: Junio C Hamano <gitster@pobox.com>
To: Firmin Martin <firminmartin24@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH][GSoC] user-manual.txt: fix empty heading of introduction
Date: Fri, 02 Apr 2021 14:29:52 -0700 [thread overview]
Message-ID: <xmqqsg482x4f.fsf@gitster.g> (raw)
In-Reply-To: <xmqqwntk2xgy.fsf@gitster.g> (Junio C. Hamano's message of "Fri, 02 Apr 2021 14:22:21 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> Firmin Martin <firminmartin24@gmail.com> writes:
>
>> For future reference, here are the content of the relevant & auto-generated files
>> before this commit.
>
> I would have expected to see "before and after". Is it too obvious
> what the postimage would be? Otherwise, a better presentation would
> be to show (an excerpt from) diff between preimage and postimage
> output.
>
> Thanks.
Another thing to look out for. I do not think git.info is the only
consumer of user-manual.txt. Does this change affect the other
consumer, user-manual.html, and if so how?
next prev parent reply other threads:[~2021-04-02 21:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-02 12:13 [PATCH][GSoC] user-manual.txt: fix empty heading of introduction Firmin Martin
2021-04-02 21:22 ` Junio C Hamano
2021-04-02 21:29 ` Junio C Hamano [this message]
2021-04-02 22:23 ` Junio C Hamano
2021-04-03 5:16 ` Bagas Sanjaya
2021-04-04 0:46 ` Junio C Hamano
2021-04-04 4:07 ` [PATCH v2 0/1] user-manual.txt: assign preface an id and a title Firmin Martin
2021-04-04 4:07 ` [PATCH v2 1/1] " Firmin Martin
2021-04-04 6:21 ` Junio C Hamano
2021-04-04 4:31 ` [PATCH v2 0/1] " Firmin Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqsg482x4f.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=firminmartin24@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.