From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id E065C1FAED for ; Wed, 25 Oct 2017 01:25:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751886AbdJYBZ4 (ORCPT ); Tue, 24 Oct 2017 21:25:56 -0400 Received: from pb-smtp1.pobox.com ([64.147.108.70]:59783 "EHLO sasl.smtp.pobox.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751870AbdJYBZ4 (ORCPT ); Tue, 24 Oct 2017 21:25:56 -0400 Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id A2504AAD06; Tue, 24 Oct 2017 21:25:55 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=80+lelwq30XRQc3BUcXvN6jWVxw=; b=xxodNp ughnYxYzsQNkChA8NIVNGiFzx9f89SZSfs9p03Tg6YtIqiKqixH3mRdphItfoM6H BCyJNZ24sR7nc7qu5fenZduL4dWXAiMH26H1imlAv+LzM8UKJW92rcF/eCoLjXa+ QpiNYPrC5xXYQNr3bG7Fl+vpsB9zZqg46UeP4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=LMiD22zcV1xVMJKd1l8YgN8TO8FNzToE 3OfbDYHfAzmp945RO1u3MUUEtrCfnM6UgscLxBB87ECInH/HubsTyF8RmadSkLqk KYGrHNsc0/y6MgCoYzQ0Em4kH17vchXt/EuhjeLRDwVnGr2ozoHUP7nvSjkOJfuF rDIagEKwJk8= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 98F52AAD05; Tue, 24 Oct 2017 21:25:55 -0400 (EDT) Received: from pobox.com (unknown [104.132.0.95]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id EA782AAD03; Tue, 24 Oct 2017 21:25:54 -0400 (EDT) From: Junio C Hamano To: Brandon Williams Cc: Stefan Beller , bturner@atlassian.com, git@jeffhostetler.com, git@vger.kernel.org, jonathantanmy@google.com, jrnieder@gmail.com, peff@peff.net, wyan@google.com Subject: Re: [WIP PATCH] diff: add option to ignore whitespaces for move detection only References: <20171024000931.14814-1-sbeller@google.com> <20171024184809.GC79163@google.com> Date: Wed, 25 Oct 2017 10:25:53 +0900 In-Reply-To: <20171024184809.GC79163@google.com> (Brandon Williams's message of "Tue, 24 Oct 2017 11:48:09 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 72485BBA-B923-11E7-918C-8EF31968708C-77302942!pb-smtp1.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Brandon Williams writes: > One simple idea would be to convert the single 'flag' into various bit > fields themselves, that way if you need to add a new flag you would just > make a new bit field. I'm unaware of any downsides of doing so (though > i may be missing something) but doing so would probably cause a bit of > code churn. The reason why people want to have their own bit in the flags word is because they want to use DIFF_OPT_{SET,CLR,TST,TOUCHED} but they do not want to do the work to extend them beyond a single word. I think it is doable by making everything a 1-bit wide bitfield without affecting existing users.