From: Junio C Hamano <gitster@pobox.com>
To: Han-Wen Nienhuys <hanwen@google.com>
Cc: git@vger.kernel.org, peff@peff.net, bmwill@google.com
Subject: Re: [PATCH 0/3] Comment fixes
Date: Wed, 27 Sep 2017 09:13:00 +0900 [thread overview]
Message-ID: <xmqqshf980dv.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170926112150.21850-1-hanwen@google.com> (Han-Wen Nienhuys's message of "Tue, 26 Sep 2017 13:21:47 +0200")
Han-Wen Nienhuys <hanwen@google.com> writes:
> follow more commit log conventions; verified it compiled (yay).
;-)
> (should I send patches that are in 'pu' again as well?)
Because these look more or less independent changes that can be
queued on separate topics, I do not think resending is needed at
all, even though mentioning that these do *not* replace what is
queued like you just did is an excellent way to prevent the
maintainer from making stupid mistakes. Thanks.
> Han-Wen Nienhuys (3):
> real_path: clarify return value ownership
> read_gitfile_gently: clarify return value ownership.
> string-list.h: move documentation from Documentation/api/ into header
>
> Documentation/technical/api-string-list.txt | 209 ----------------------------
> abspath.c | 4 +
> setup.c | 3 +-
> string-list.h | 192 +++++++++++++++++++++----
> 4 files changed, 168 insertions(+), 240 deletions(-)
> delete mode 100644 Documentation/technical/api-string-list.txt
>
> --
> 2.14.1.821.g8fa685d3b7-goog
next prev parent reply other threads:[~2017-09-27 0:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-26 11:21 [PATCH 0/3] Comment fixes Han-Wen Nienhuys
2017-09-26 11:21 ` [PATCH 1/3] real_path: clarify return value ownership Han-Wen Nienhuys
2017-09-26 11:21 ` [PATCH 2/3] read_gitfile_gently: " Han-Wen Nienhuys
2017-09-26 11:21 ` [PATCH 3/3] string-list.h: move documentation from Documentation/api/ into header Han-Wen Nienhuys
2017-09-27 0:13 ` Junio C Hamano [this message]
2017-10-02 23:50 ` [PATCH 0/3] Comment fixes Brandon Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqshf980dv.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=hanwen@google.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.