All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Ben Peart <peartben@gmail.com>
Cc: Christian Couder <christian.couder@gmail.com>,
	git@vger.kernel.org, Jeff King <peff@peff.net>,
	Ben Peart <Ben.Peart@microsoft.com>,
	Jonathan Tan <jonathantanmy@google.com>,
	Lars Schneider <larsxschneider@gmail.com>,
	Jonathan Nieder <jrnieder@gmail.com>,
	Christian Couder <chriscool@tuxfamily.org>
Subject: Re: [PATCH v2] sub-process: print the cmd when a capability is unsupported
Date: Wed, 16 Aug 2017 14:55:40 -0700	[thread overview]
Message-ID: <xmqqshgri3dv.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <xmqq4lt7pir9.fsf@gitster.mtv.corp.google.com> (Junio C. Hamano's message of "Wed, 16 Aug 2017 09:41:46 -0700")

Junio C Hamano <gitster@pobox.com> writes:

> Ben Peart <peartben@gmail.com> writes:
>
>>> -			warning("external filter requested unsupported filter capability '%s'",
>>> -				p);
>>> +			warning("subprocess '%s' requested unsupported capability '%s'",
>>> +				process->argv[0], p);
>>>   		}
>>>   	}
>>>   
>>>
>>
>> This one is even cleaner.  Thanks Lars for pointing out the fact we
>> already had the cmd name.  Looks good.
>
> Thanks, all.  Will queue.

I still think we would want to turn warning() to die(), but it
probably is better to do so in a separate follow-up patch.  That
will give us a good place to record the reason why the current "just
call a warning() and pretend as if nothing bad happend" is wrong.


  reply	other threads:[~2017-08-16 21:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-16 12:40 [PATCH v2] sub-process: print the cmd when a capability is unsupported Christian Couder
2017-08-16 14:06 ` Ben Peart
2017-08-16 16:41   ` Junio C Hamano
2017-08-16 21:55     ` Junio C Hamano [this message]
2017-09-11  3:27       ` Junio C Hamano
2017-09-11 12:34         ` Ben Peart
2017-09-12 12:02         ` Lars Schneider
2017-08-16 15:48 ` Lars Schneider

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqshgri3dv.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=Ben.Peart@microsoft.com \
    --cc=chriscool@tuxfamily.org \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jonathantanmy@google.com \
    --cc=jrnieder@gmail.com \
    --cc=larsxschneider@gmail.com \
    --cc=peartben@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.